Change operations request types from bare structs to pointers#105
Open
c1-dev-bot[bot] wants to merge 1 commit into
Open
Change operations request types from bare structs to pointers#105c1-dev-bot[bot] wants to merge 1 commit into
c1-dev-bot[bot] wants to merge 1 commit into
Conversation
All SDK method signatures now accept *operations.SomeType instead of operations.SomeType for the request parameter. This enables better use of interfaces and generics when working with the SDK, with no realistic performance impact given typical GC escape volumes. The shared.* request types were already pointers; this makes the operations.* types consistent. IGA-732
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*operations.SomeType(pointer) instead ofoperations.SomeType(bare struct) for therequestparametershared.*request types were already pointers; this makes theoperations.*types consistent.ci/main.gobuild test to use pointer syntaxDetails
This is a breaking change for SDK consumers — callers need to prefix request literals with
&. For example:The internal utility functions (
GenerateURL,PopulateQueryParams,SerializeRequestBody) already handle both value and pointer types via reflection, so no internal changes were needed.194 method signatures updated across 40 files.
Test plan
go build ./...passesgo test ./...passesResolves IGA-732