Skip to content

Comments

Make the scheduled visit date#273

Open
Vinald wants to merge 3 commits intovrvufrom
fix/visibleScheduledDate
Open

Make the scheduled visit date#273
Vinald wants to merge 3 commits intovrvufrom
fix/visibleScheduledDate

Conversation

@Vinald
Copy link
Collaborator

@Vinald Vinald commented Feb 24, 2026

This PR focuses on;

  • Moving the pop-up to the bottom of the screen
  • Displaying the scheduled visit date on the pop-up

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the “dosing out of window” UI to appear as a bottom sheet and optionally display the scheduled visit date to the user.

Changes:

  • Convert DosingOutOfWindowDialog from a standard dialog to a BottomSheetDialogFragment and update its layout to be scrollable.
  • Add a “Scheduled date” label and pass a formatted scheduled date from ContraindicationsFragment into the dialog.
  • Modify configuration.json test resource (currently leaving it in an invalid JSON state).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
app/src/test/resources/configuration.json Updates test configuration, but currently breaks JSON structure in authSteps.
app/src/main/res/values/strings.xml Adds a formatted label for displaying the scheduled date.
app/src/main/res/layout/dialog_dosing_out_of_window.xml Wraps dialog content in a ScrollView and adds a scheduled date TextView.
app/src/main/java/com/jnj/vaccinetracker/visit/screens/ContraindicationsFragment.kt Formats and passes scheduled date into the out-of-window dialog; updates dialog construction.
app/src/main/java/com/jnj/vaccinetracker/visit/dialog/DosingOutOfWindowDialog.kt Converts dialog to a bottom sheet and renders scheduled date when provided.
Comments suppressed due to low confidence (1)

app/src/main/java/com/jnj/vaccinetracker/visit/screens/ContraindicationsFragment.kt:147

  • This dialog is shown with two different tags: VisitActivity.TAG_DIALOG_DOSING_OUT_OF_WINDOW in showOutsideTimeWindowConfirmationDialog(), but a hardcoded "TAG_DOSING_OUT_OF_WINDOW" here. Using different tags for the same dialog class can lead to duplicate dialogs and makes fragment manager lookups inconsistent. Reuse the existing VisitActivity.TAG_DIALOG_DOSING_OUT_OF_WINDOW constant here as well (or define a single shared constant).
           formatScheduledDate()
       )
       dialog.isCancelable = false
       dialog.show(requireActivity().supportFragmentManager, "TAG_DOSING_OUT_OF_WINDOW")
   }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant