Stress test parameter groups and fix from_valid bug in multi-group fill_params#84
Draft
Stress test parameter groups and fix from_valid bug in multi-group fill_params#84
Conversation
Co-authored-by: ConnorStoneAstro <78555321+ConnorStoneAstro@users.noreply.github.com>
… in fill_params Add 65 tests covering parameter groups across: - Basic group creation and graph tracking - Hierarchical models (top-level and within hierarchy) - get_values/set_values with all schemes (array, list, dict) - Varying batch dimensions (independent per group) - find_param/find_index - to_valid/from_valid and ValidContext - @forward decorator and fill_params - ActiveContext - active_cache - NodeList/NodeTuple collections - Pointer params - Dynamic/static transitions - OverrideParam - Edge cases (many groups, non-contiguous, reassignment) Fix bug in fill_params where from_valid was called without group= parameter, causing IndexError when using ValidContext with multi-group parameters. Co-authored-by: ConnorStoneAstro <78555321+ConnorStoneAstro@users.noreply.github.com>
Co-authored-by: ConnorStoneAstro <78555321+ConnorStoneAstro@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add stress test parameter group options
Stress test parameter groups and fix from_valid bug in multi-group fill_params
Mar 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1612 1612
=========================================
Hits 1612 1612
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comprehensive test coverage for parameter groups across all major caskade features, and fixes a bug discovered during testing.
Bug fix
fill_paramscalledfrom_valid(params_g, param_list_g)without passinggroup=group, causingfrom_validto re-enter its multi-group branch and attempt to iterate a single group's tensor as a list of group tensors. This produces anIndexErrorwhen usingValidContextwith multi-group parameters.Fix in
module.py:173: passgroup=grouptoself.from_valid().Test coverage (65 tests)
Original prompt
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.