This repository was archived by the owner on Jul 14, 2025. It is now read-only.
Improved logic in "TransferFrom" function#143
Open
rtroncosogar wants to merge 3 commits intoConsensys:masterfrom
Open
Improved logic in "TransferFrom" function#143rtroncosogar wants to merge 3 commits intoConsensys:masterfrom
rtroncosogar wants to merge 3 commits intoConsensys:masterfrom
Conversation
It seems more logical than before, cause makes more sense if first we discount the value available and then that value is transferred
|
I believe this would violate the intent of the change, see: ethereum/EIPs#717 |
DONALDSULLENDER
approved these changes
Nov 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone,
According to my opinion, this suggestion makes more sense, because first at all will take the token from the owner and just then the tokens will be added to the recipient.
Greetings!