Conversation
| VWIN = "iverilog" #Windows verilog 6/25/21 | ||
| VEXE = "iverilog" #Ubuntu/macOS verilog 6/25/21 | ||
| CPPEXE = "g++" #Ubuntu/macOS C++ 6/22/21 | ||
| CPPWIN = "g++" #Windows C++ 6/22/21 |
There was a problem hiding this comment.
This file is modified by just line breaks changes, it seems?
Can you please make sure to commit only the actual changes, and not line breaks? Adding these changes makes it hard to track the development and makes the review difficult.
Please check with "git diff" before the pull request, and make sure such changes are not committed.
pradeeban
left a comment
pradeeban
left a comment
There was a problem hiding this comment.
Pls submit a new pull request without the changes caused by just line breaks.
mkconcore.py has many new changes tracked below - all seem to be just line breaks.
|
New pull request suggested. |
| resp.status_code = 500 | ||
| return resp | ||
|
|
||
| @app.route('/build/<dir>', methods=['POST']) |
There was a problem hiding this comment.
dir should be the whole input as in "demo/sample" rather than hard-coding "demo" below.
|
|
||
| @app.route('/build/<dir>', methods=['POST']) | ||
| def build(dir): | ||
| makestudy_dir = "demo" + "/" + dir |
There was a problem hiding this comment.
makestduy_dir = dir
(therefore, avoid makestudy_dir)
| makestudy_dir = "demo" + "/" + dir | ||
| cur_path = os.getcwd() | ||
| concore_path = os.path.abspath(os.path.join(cur_path, '../../')) | ||
| dir_path = os.path.abspath(os.path.join(concore_path, dir)) |
There was a problem hiding this comment.
"dir" here must be replaced by a splitted version to get the "sample" below:
split by "/"
as in dir = demo/sample <--- we want the "sample" here.
2 participants
No description provided.