Skip to content

add patch for https://github.com/magento/magento2/issues/18154#5

Open
davidverholen wants to merge 1 commit into
ConvertGroupsAS:masterfrom
davidverholen:master
Open

add patch for https://github.com/magento/magento2/issues/18154#5
davidverholen wants to merge 1 commit into
ConvertGroupsAS:masterfrom
davidverholen:master

Conversation

@davidverholen

Copy link
Copy Markdown
Contributor

No description provided.

@nicobatty

Copy link
Copy Markdown

@davidverholen I don't think this patch really fix the issue. It reverse the problem basically.

I am still getting an error if I try to save a product tier price with a specific group and website id as it get filtered out in prepareOriginalDataToCompare function call.

@nicobatty

Copy link
Copy Markdown

@davidverholen

I don't see the use of the if condition in the prepareOriginalDataToCompare method: $isGlobal === $this->isWebsiteGlobal((int)$data['website_id'])

I think it can be removed.

@nicobatty

Copy link
Copy Markdown

@davidverholen

Also in the SaveHandler class, there is no isWebsiteGlobal function so it is not going to work.

@davidverholen

Copy link
Copy Markdown
Contributor Author

@nicobatty thanks for the review, I'll try to look into it this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants