add patch for https://github.com/magento/magento2/issues/18154#5
Open
davidverholen wants to merge 1 commit into
Open
add patch for https://github.com/magento/magento2/issues/18154#5davidverholen wants to merge 1 commit into
davidverholen wants to merge 1 commit into
Conversation
|
@davidverholen I don't think this patch really fix the issue. It reverse the problem basically. I am still getting an error if I try to save a product tier price with a specific group and website id as it get filtered out in |
|
I don't see the use of the if condition in the I think it can be removed. |
|
Also in the |
Contributor
Author
|
@nicobatty thanks for the review, I'll try to look into it this week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.