Skip to content

fix: resolve compilation, typecheck and formatting errors#361

Merged
Abd-Standard merged 7 commits into
Core-Foundry:mainfrom
michaelvic123:main
Jun 30, 2026
Merged

fix: resolve compilation, typecheck and formatting errors#361
Abd-Standard merged 7 commits into
Core-Foundry:mainfrom
michaelvic123:main

Conversation

@michaelvic123

Copy link
Copy Markdown
Contributor

Changes

  • Fixed compilation errors in contract tests
  • Resolved typecheck and syntax errors in events-server
  • Fixed formatting issues

Testing

Verified fixes locally before submitting

michaelvic123 and others added 6 commits June 25, 2026 20:39
- Instantiate EventDeduplicationService with database in main entrypoint
- Pass deduplication service to EventSubscriber constructor
- Fix jest.config.js syntax error (missing comma)
- Enable duplicate event detection and logging
feat: wire up EventDeduplicationService in EventSubscriber
- Add test for zero usages rejection
- Register edge_case_test module in lib.rs
- Improve assertion quality with expected panic messages
- Add missing IntoVal import in preferences_test.rs
- Remove undefined pause_key references in autoshare_logic.rs
- Remove duplicate test_create_group_with_zero_usages_fails definition
feat: expand contract test coverage for edge cases and assertions
@drips-wave

drips-wave Bot commented Jun 29, 2026

Copy link
Copy Markdown

Hey @michaelvic123! 👋 It looks like this PR isn't linked to any issue.

If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g., Closes #123), or by clicking a button below:

Issue Title
#250 [Backend] Implement Webhook Delivery Logs API Link to this issue
#255 [Testing] Improve Smart Contract Test Coverage Link to this issue
#256 [Backend] Implement Notification Queue Metrics Service Link to this issue
#259 [Backend] Add Notification Deduplication Mechanism Link to this issue

ℹ️ Learn more about linking PRs to issues

@Abd-Standard Abd-Standard merged commit 1063e39 into Core-Foundry:main Jun 30, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants