COR-5907 Type install-config JSON with structs instead of map[string…#14
Open
ashwin-corridor wants to merge 1 commit into
Open
COR-5907 Type install-config JSON with structs instead of map[string…#14ashwin-corridor wants to merge 1 commit into
ashwin-corridor wants to merge 1 commit into
Conversation
…]any - Replace map[string]any literals in all five installX functions with strongly-typed structs: claudeHooksConfig (shared by Claude, Droid, Codex), cursorConfig, and cascadeConfig. - Add writeClaudeStyleConfig helper for read-merge-write pattern that preserves unrelated top-level keys (permissions, mcpServers, etc.). - Add writeJSONFile helper to eliminate marshal/mkdir/write boilerplate. - Collapse Codex tool matcher into codexToolMatcher constant shared by PreToolUse and PostToolUse. - Add golden-file tests pinning each install function's output.
ashwin-corridor
changed the title
![corridor-security[bot]](https://avatars.githubusercontent.com/in/1177339?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary: This PR refactors hook installation config generation into typed structs and shared JSON-writing helpers, with tests for generated Claude/Cursor/Droid/Codex/Cascade configs. No exploitable security vulnerabilities were identified.
Risk: Low risk. The changes affect local CLI configuration file generation and do not introduce network endpoints, authentication boundaries, or new execution of untrusted command strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…]any