fix: honor run cwd in command templates#235
Open
Bortlesboat wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cortex run --cwd <dir> --command <name>pass the requested run cwd into custom command templates.--cwdis not provided.Why
This addresses PlatformNetwork/bounty-challenge#53357. The command registry already scans commands from
--cwd, but{{cwd}}expansion usedstd::env::current_dir()instead of the run cwd override.Verification
cargo test -p cortex-cli --test run_command_cwdcargo check -p cortex-clicargo fmt --check --package cortex-cligit diff --checkNote:
cargo test -p cortex-cli run_cmd::tests::test_output_format_displayis currently blocked on upstreammainby an unrelated private import insrc/cortex-cli/src/agent_cmd/tests.rs.