Skip to content

fix: normalize stats model aggregation#237

Open
Bortlesboat wants to merge 1 commit into
CortexLM:mainfrom
Bortlesboat:fix/stats-model-case-aggregation
Open

fix: normalize stats model aggregation#237
Bortlesboat wants to merge 1 commit into
CortexLM:mainfrom
Bortlesboat:fix/stats-model-case-aggregation

Conversation

@Bortlesboat
Copy link
Copy Markdown

Fixes PlatformNetwork/bounty-challenge#53225.

Summary

  • Normalize cortex stats model aggregation keys to lowercase before updating by_model.
  • Add a CLI regression test that writes two session files whose model names differ only by case and verifies stats --json reports one merged model row.

Verification

  • cargo fmt --check --package cortex-cli
  • cargo test -p cortex-cli --test stats_model_case
  • cargo check -p cortex-cli
  • git diff --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] cortex stats --verbose splits the same model into separate By Model rows when only letter case differs

1 participant