Skip to content

Tidy /goto invalid number error#238

Open
DanielButler1 wants to merge 1 commit into
CortexLM:mainfrom
DanielButler1:fix/goto-invalid-number-message
Open

Tidy /goto invalid number error#238
DanielButler1 wants to merge 1 commit into
CortexLM:mainfrom
DanielButler1:fix/goto-invalid-number-message

Conversation

@DanielButler1
Copy link
Copy Markdown

Summary

  • remove the second label-style colon from invalid /goto number errors
  • quote the invalid token so the event-loop Error: prefix reads cleanly
  • tighten the /goto validation test around the exact message

Related: PlatformNetwork/bounty-challenge#53425

Verification

  • rustfmt --edition 2024 --check src/cortex-tui/src/commands/executor/navigation.rs src/cortex-tui/src/commands/executor/tests.rs
  • git diff --check
  • cargo test -p cortex-tui commands::executor::tests::test_goto_validation
  • cargo check -p cortex-tui

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant