Skip to content

fix: include purge data directories#243

Open
Bortlesboat wants to merge 1 commit into
CortexLM:mainfrom
Bortlesboat:fix/uninstall-purge-data-dirs
Open

fix: include purge data directories#243
Bortlesboat wants to merge 1 commit into
CortexLM:mainfrom
Bortlesboat:fix/uninstall-purge-data-dirs

Conversation

@Bortlesboat
Copy link
Copy Markdown

Summary

  • Include ~/.cortex/delegates and ~/.cortex/snapshots in the data directories collected by cortex uninstall --purge.
  • Add temp-home coverage for the uninstall collector so these generated data directories are listed for purge.
  • Fix a test-only import for read_file_with_encoding so focused cortex-cli unit tests compile on current main.

Related to PlatformNetwork/bounty-challenge#52677.

Verification

  • cargo test -p cortex-cli test_collect_cortex_home_items_includes_delegate_and_snapshot_dirs -- --nocapture
  • cargo check -p cortex-cli
  • cargo fmt --check --package cortex-cli
  • git diff --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant