Respect startup update-check config#244
Draft
GreyforgeLabs wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Respects the existing
check_for_update_on_startupconfig flag before starting background update checks in both CLI command mode and TUI startup.The typed engine config already loads this field from
config.toml, but the startup paths were not consulting it:check_for_updates_background()UpdateManager::check_update()taskWith this change, setting
check_for_update_on_startup = falseprevents those startup update checks.Related Issue
Fixes PlatformNetwork/bounty-challenge#50048
Type of Change
Checklist
Testing
Note: full default-feature check in this local environment is blocked by missing system
alsa.pcforalsa-sys; the no-audio check coverscortex-cliandcortex-tuicompilation for this patch.