Skip to content

fix: include snapshot diff in json output#245

Open
Bortlesboat wants to merge 1 commit into
CortexLM:mainfrom
Bortlesboat:fix/debug-snapshot-json-diff
Open

fix: include snapshot diff in json output#245
Bortlesboat wants to merge 1 commit into
CortexLM:mainfrom
Bortlesboat:fix/debug-snapshot-json-diff

Conversation

@Bortlesboat
Copy link
Copy Markdown

Summary

  • Include diff metadata in cortex debug snapshot --json --diff output instead of dropping the flag on the JSON path.
  • Keep the existing placeholder behavior explicit by returning a not_implemented diff status and message.
  • Add CLI coverage that exercises debug snapshot --json --diff and asserts the JSON diff metadata is present.

Related to PlatformNetwork/bounty-challenge#45699.

Verification

  • cargo test -p cortex-cli --test debug_snapshot_json_diff debug_snapshot_json_includes_diff_when_requested -- --nocapture
  • cargo check -p cortex-cli
  • cargo fmt --check --package cortex-cli
  • git diff --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant