Skip to content

fix: avoid github status workflow false positives#275

Open
Bortlesboat wants to merge 1 commit into
CortexLM:mainfrom
Bortlesboat:fix/github-status-workflow-detection
Open

fix: avoid github status workflow false positives#275
Bortlesboat wants to merge 1 commit into
CortexLM:mainfrom
Bortlesboat:fix/github-status-workflow-detection

Conversation

@Bortlesboat
Copy link
Copy Markdown

Fixes PlatformNetwork/bounty-challenge#43632.

Tightens cortex github status workflow detection so unrelated workflows that merely mention Cortex are not reported as installed. Detection now requires the generated Cortex workflow marker and the cortex github run command shape emitted by cortex github install.

Verification:

  • cargo test -p cortex-cli --test github_status_workflow_detection -- --nocapture
  • cargo check -p cortex-cli
  • cargo fmt --check --package cortex-cli
  • git diff --check

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [v0.0.7] cortex github status falsely reports "[OK] Cortex workflow is installed" for any workflow containing the word "Cortex"

1 participant