Skip to content

fix: preserve double-digit command placeholders #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thedalbee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preserve double-digit command placeholders #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/cortex-commands/src/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,8 @@ pub fn substitute_placeholders(template: &str, arguments: &str) -> String {
// Find the highest numbered placeholder
let max_placeholder = find_max_placeholder(&result);

// Replace numbered placeholders
for i in 1..=max_placeholder {
// Replace longer placeholders first so `$1` does not corrupt `$10`.
for i in (1..=max_placeholder).rev() {
let placeholder = format!("${i}");
let replacement = if i == max_placeholder {
// Last placeholder captures all remaining arguments
Expand Down Expand Up @@ -374,6 +374,17 @@ No closing delimiter"#;
assert_eq!(result, "A: only_one, B: , C: ");
}

#[test]
fn test_substitute_two_digit_placeholders_before_prefixes() {
let template = "Run $1 and item $10";
let result = substitute_placeholders(
template,
"alpha beta gamma delta epsilon zeta eta theta iota kappa",
);

assert_eq!(result, "Run alpha and item kappa");
}

#[test]
fn test_command_parse() {
let content = r#"---
Expand Down