Skip to content

fix: filter stats sessions without timestamps#282

Open
Bortlesboat wants to merge 1 commit into
CortexLM:mainfrom
Bortlesboat:fix/stats-days-invalid-timestamps
Open

fix: filter stats sessions without timestamps#282
Bortlesboat wants to merge 1 commit into
CortexLM:mainfrom
Bortlesboat:fix/stats-days-invalid-timestamps

Conversation

@Bortlesboat
Copy link
Copy Markdown

Fixes PlatformNetwork/bounty-challenge#53249. This makes stats date filtering skip sessions whose timestamp is missing or cannot be parsed, instead of counting them inside every --days window. Verification: cargo test -p cortex-cli --test stats_days_timestamp_filter -- --nocapture; cargo check -p cortex-cli; cargo fmt --check --package cortex-cli; git diff --check.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][v0.0.7] stats --days skips sessions only when timestamp parses and is before the window; missing or bad timestamps bypass the filter

1 participant