Skip to content

fix(cli): detect GraphQL files in run attachments#283

Open
ChuanWeis wants to merge 1 commit into
CortexLM:mainfrom
ChuanWeis:codex/cortex-graphql-mime
Open

fix(cli): detect GraphQL files in run attachments#283
ChuanWeis wants to merge 1 commit into
CortexLM:mainfrom
ChuanWeis:codex/cortex-graphql-mime

Conversation

@ChuanWeis
Copy link
Copy Markdown

Summary

  • map .graphql and .gql run attachments to application/graphql
  • add coverage for both extensions in the run-command MIME tests

Addresses PlatformNetwork/bounty-challenge#53309.

Verification

  • git diff --check
  • cargo test -p cortex-cli mime_type_from_extension could not be run locally because cargo is not installed/exposed on this machine.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@ChuanWeis
Copy link
Copy Markdown
Author

Update: I installed the Rust toolchain locally and reran validation for this branch.

  • cargo check -p cortex-cli passes.
  • cargo test -p cortex-cli mime_type_from_extension currently fails before reaching the MIME test because the upstream test module src/cortex-cli/src/agent_cmd/tests.rs imports private read_file_with_encoding. That compile error appears unrelated to this GraphQL MIME mapping change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant