Skip to content

fix(core): preserve table width remainders#284

Open
Bortlesboat wants to merge 1 commit into
CortexLM:mainfrom
Bortlesboat:fix/table-width-remainder
Open

fix(core): preserve table width remainders#284
Bortlesboat wants to merge 1 commit into
CortexLM:mainfrom
Bortlesboat:fix/table-width-remainder

Conversation

@Bortlesboat
Copy link
Copy Markdown

Summary:

  • Preserve leftover width when proportional table allocation floors fractional shares.
  • Add a regression test for the in-between width case where the old logic rendered narrower than available space.

Verification:

  • cargo test -p cortex-core test_column_width_distribution_preserves_available_space -- --nocapture
  • cargo test -p cortex-core markdown::table -- --nocapture
  • cargo test -p cortex-core --lib
  • cargo check -p cortex-core
  • cargo fmt --check --package cortex-core
  • git diff --check

Related: PlatformNetwork/bounty-challenge#53337

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant