Skip to content

fix(feedback): warn when feedback history files are unreadable#303

Open
694410194 wants to merge 1 commit into
CortexLM:mainfrom
694410194:codex/feedback-history-corruption-warnings
Open

fix(feedback): warn when feedback history files are unreadable#303
694410194 wants to merge 1 commit into
CortexLM:mainfrom
694410194:codex/feedback-history-corruption-warnings

Conversation

@694410194
Copy link
Copy Markdown

Summary

  • load feedback history entries through a helper that keeps valid entries while collecting read/parse warnings for corrupted JSON files
  • print those warnings to stderr instead of silently dropping bad files
  • stop claiming No feedback history found. in text mode when the directory contains unreadable feedback entries, and add focused helper tests

Verification

  • git diff --check
  • static check that run_history now calls load_feedback_entries(&feedback_dir) and prints warnings to stderr
  • added focused tests covering invalid JSON warnings and mixed valid+invalid entry loading
  • rustc --version (not available in this environment, so cargo-based checks could not be run here)

Fixes #53182
/claim #53182

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant