fix: register active runtime and allow dreaming config#650
fix: register active runtime and allow dreaming config#650holeshotclaw wants to merge 1 commit intoCortexReach:masterfrom
Conversation
|
This PR currently has merge conflicts with the base branch (
Please:
Once that's done, the review pipeline will pick it up automatically on the next scan and do a full pass. Thanks for your patience. |
rwmjhb
left a comment
There was a problem hiding this comment.
Requesting changes because the new runtime registration can crash hosts that do not expose this API.
index.ts:2034—api.registerMemoryCapability(...)is called unconditionally.
The existingtest/recall-text-cleanup.test.mjsharness has noregisterMemoryCapabilitymethod (test/recall-text-cleanup.test.mjs:37-58), andnpm testfails attest/recall-text-cleanup.test.mjs:221withTypeError: api.registerMemoryCapability is not a function. More importantly, this suggests older or alternate OpenClaw hosts can fail plugin registration before lifecycle hooks/services are registered. Please feature-detect the method, add a compatibility fallback, or make the call safely optional.
A few non-blocking follow-ups:
-
index.ts:2039-2040:getMemorySearchManager()eagerly performsstore.stats()andembedder.test()before any manager method is used. That adds DB/network latency to manager construction and can returnmanager: nulleven when search/read paths would otherwise work. Please compute status/probe data lazily insidestatus()/ probe methods. -
index.ts:2083-2087: search results reportstartLine: 1, butreadFile()returns a synthetic markdown document where memory text starts after the metadata header, around line 8. Citations can point at# Memory ...instead of the matched text. Please offset the returned line range or make search/read line numbering consistent. -
index.ts:2120-2122:probeVectorAvailability()only callsembedder.test(), so it reports embedding health rather than vector-store/retrieval health. Please probe the store/retriever path as well, or rename the probe semantics.
The runtime registration is the right direction, but the host API compatibility crash needs to be fixed before merge.
|
This PR currently has merge conflicts with the base branch (
Please:
Once that's done, the review pipeline will pick it up automatically on the next scan and do a full pass. Thanks for your patience. |
Summary
dreamingconfig block so OpenClaw sidecar dreaming can be configured when this plugin owns the memory slotTesting