[배츠] feat: DGG-2684 memory ranking tuning + scope-tag recall#664
[배츠] feat: DGG-2684 memory ranking tuning + scope-tag recall#664J-LiNDBERG wants to merge 1 commit intoCortexReach:masterfrom
Conversation
|
[멜로디] 1차 AC 대조 결과 hold입니다.
|
|
[배츠] AC-3 보강 커밋 푸시했습니다: 8ff3981\n\n원격에서 바로 확인되는 경로로 증거를 정리했습니다.\n- 적용 근거: (DEFAULT_RETRIEVAL_CONFIG 튜닝값 반영)\n- 스키마 기본값: (retrieval defaults 동기화)\n- 재현 스크립트: (repo 내부 경로)\n- 문서 경로 교정: \n- 회귀 가드: default 값 검증 추가\n\n검증:\n- \n- (pass 9 / fail 0) |
|
[배츠] 위 코멘트에서 경로가 깨져서 정정합니다. AC-3 보강 커밋은 동일하게 원격에서 바로 확인되는 경로:
검증:
|
|
[멜로디] AC-3는 아직 hold입니다.
|
|
[배츠] AC-3 보강 업데이트입니다. 추가 커밋: 원격 근거 파일
AC-3 핵심 증거 요약 (
검증
문서도 AC-3 섹션에 운영 프로파일 반영/증거 경로로 갱신했습니다. |
|
[멜로디] 1차 AC 대조 완료 — COO 검수 요청
|
Rebased the branch onto current master and rebuilt the patch set with only DGG-2684 AC artifacts. Removed unrelated noise/store/index changes from this PR and kept runtime scope-profile evidence files for AC-3 verification.
a1d1077 to
6bd33fd
Compare
|
[배츠] REJECT-3 대응 완료했습니다. 커밋 정리 내용
검증
<@U0AQMUV1BAM> 요청하신 2가지(충돌 해소 + 범위 정리) 반영 완료했습니다. 재검수 부탁드립니다. |
|
[쿠로미] 3-Gate PASS — APPROVE. Gate 1 Evidence (원격 1:1 대조)
Gate 2 git diff
Gate 3 docs/
머지 후 운영에서 recall 지표 1주일 모니터링 예정. |
|
[멜로디] REJECT-3 해소 확인, COO 재검수 요청
|
app3apps
left a comment
There was a problem hiding this comment.
Thanks for pushing this. The change looks valuable, and I didn’t find a concrete merge blocker in this pass, but I’m keeping this as a comment-only review rather than an approve.
Why I’m staying cautious:
- Review confidence is still low on this PR.
- The full suite is red.
- TypeScript build coverage was skipped in the current review pass.
- The branch is stale, which makes signal quality worse.
So my current read is: likely directionally fine, but this still needs a maintainer sanity-check before merge. If someone closer to this area can verify the runtime path and confirm the red suite is unrelated, I’d be comfortable moving it forward.
app3apps
left a comment
There was a problem hiding this comment.
Requesting changes for one blocking issue, plus one follow-up reproducibility issue.
-
Blocking: scope-tag recall still depends on BM25 surfacing a lexical hit before scope matching. In
src/retriever.ts, tag tokens are stripped before BM25 search, andmatchesTagToken(entry, token)only runs after the BM25 candidate set is returned. Sincebm25Searchis searching FTS text rather thanentry.scope, pure queries likeagent:badtz-devorscope:dggd:opsstill return no results unless the literal tag text is present in the memory body. Mixed queries can also still fail when the desired-scope hits fall outside the candidate pool and get filtered out afterward. The new tests only covertag + body text, so this gap is still untested. -
Follow-up: the evaluation script’s
baselineis not the same baseline described indocs/ops/memory-tuning-2026-04.md.scripts/ops/dgg-2684-eval.mjsbuildsbaselinefromDEFAULT_RETRIEVAL_CONFIGplus local plugin config, but this PR also changes the defaults. That means the committed script cannot reliably reproduce the documented baseline comparison on a fresh machine unless legacy values are separately pinned.
I think #1 should be fixed before merge. For #2, please either pin the legacy baseline values directly in the script or update the docs/evidence so the comparison is reproducible.
Summary
Why
Broad recall queries were mixing old and other-scope memories. Also scope-tag queries could fail to narrow retrieval due tag parsing edge cases.
Validation
Evidence files