feat: bulkStore batch write + SmartExtractor optimization (Issue #665, #666)#669
Merged
rwmjhb merged 7 commits intoCortexReach:masterfrom Apr 20, 2026
Merged
Conversation
- Add bulkStore() method that acquires lock once for multiple entries - Reduces lock contention for auto-capture writes - Fixes Issue CortexReach#665
- Filter out undefined/null entries - Skip empty text - Early return for empty validEntries (skip lock) - Add edge case tests Fixes potential crashes with invalid input
…ce lock contention (Issue CortexReach#666) - Add buildStoreEntry() helper to construct entries without writing - Add createEntries array to collect all CREATE decisions - Pass createEntries to all handler methods (handleProfileMerge, handleSupersede, handleContextualize, handleContradict, handleMerge) - Wrap direct store.store() calls with if(createEntries) guards - Final bulkStore() call at end of extractAndPersist() reduces N locks to 1 Changes: - src/smart-extractor.ts: batch creation logic - test/smart-extractor-bulk-store.test.mjs: 9 tests - test/smart-extractor-bulk-store-edge-cases.test.mjs: 17 tests Note: SUPERSEDE/CONFLICT still require 2 locks per decision (cannot batch due to ID dependency)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements batch write optimization for auto-capture to reduce lock contention:
Changes
Test Results
Lock Reduction
Related Issues