fix(store): Issue #670 realpath:false + maintainer suggestions

[jlin53882]

Summary

Fix Issue #670: ENOENT from proper-lockfile.realpath() after proactive stale lock cleanup.

Incorporates maintainer feedback from #674 (comment)

Root Cause

The proactive stale lock cleanup (PR #626) deletes a stale .memory-write.lock file. When proper-lockfile subsequently tries to acquire the lock, it calls s.realpath() on the now-deleted file, resulting in ENOENT.

Fix

1. Add

ealpath: false to lockfile.lock()

ypescript const release = await lockfile.lock(this.config.dbPath, { lockfilePath: lockPath, // explicit artifact path realpath: false, // Fix #670: skip realpath() to avoid ENOENT retries: { retries: 10, factor: 2, minTimeout: 1000, // James conservative settings maxTimeout: 30000, }, stale: 10000, onCompromised: (err: unknown) => { isCompromised = true; compromisedErr = err; }, });

Key changes:

• lockfile.lock(target, { lockfilePath: artifact }) — separates lock TARGET (dbPath) from artifact path

ealpath: false — avoids ENOENT when stale artifact was already deleted

• lockfilePath explicit option — avoids ambiguity with proper-lockfile v4 mkdir behavior

2. Update stale cleanup for proper-lockfile v4

ypescript if (ageMs > staleThresholdMs && stat.isDirectory()) { rmSync(lockPath, { recursive: true, force: true }); }

• Only removes DIRECTORY artifacts (proper-lockfile v4 uses mkdir)
• Uses
  mSync instead of unlinkSync for proper directory removal

Validation

• ✅
  pm run test:storage-and-schema
• ✅
  pm run test:core-regression
• ✅ Runtime targeted MemoryStore bulk/lock validation (maintainer confirmed)

Related

• Issue: [BUG] ENOENT from proper-lockfile realpath() after proactive stale lock cleanup #670
• Maintainer PR: fix(store): add realpath:false to prevent ENOENT after stale lock cleanup (Issue #670) #674
• Related: fix: resolve stale lock and same-instance write contention (#622, #623) #626 (introduced stale lock cleanup), [openclaw] Uncaught exception: Error: Unable to update lock within the stale threshold #415 (ECOMPROMISED handling)

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.