fix: address all 5 maintainer review blockers (PR #662)

[jlin53882]

修復 PR #662 維護者提出的 5 個 Blocking 問題

基於 rwmjhb review（#4170815598）全部修復：

---

Fix #1：runWithFileLock() 不再重複執行 mutation

問題：原本 try/catch 包裹整個 acquire() + fn() 區塊，若 fn() 在 Redis lock 取得後失敗，會被 catch 捕捉並觸發 file-lock fallback，等於同一筆 mutation 執行兩次。

修復：引入 lockAcquired flag，區分：

• lockAcquired=false → lock 取得失敗 → fallback 合理
• lockAcquired=true + fn() 失敗 → operation 錯誤，直接 re-throw

let lockAcquired = false;
let release: (() => Promise<void>) | null = null;
try {
  release = await redisManager.acquire(redisLockKey, redisLockTTL);
  lockAcquired = true;
  return await fn();     // ← fn() 錯誤往上拋，不 trigger fallback
} catch (err) {
  if (!lockAcquired) {
    // lock 取得失敗 → fallback 合理
    console.warn("...falling back to file lock:", err);
  } else {
    // lock 已取得但 fn() 失敗 → operation 錯誤，不 fallback
    throw err;
  }
} finally {
  if (release) { try { await release(); } catch {} }
}

---

Fix #2：Redis TTL 從 60s → 180s

問題：無 renewal 機制，長 operation 期間 lock 過期會造成 race condition。

修復：TTL 延長到 180 秒作為短期緩解。完整修復需 Phase 2 加 TTL renewal background task。

---

Fix #3：Redis 測試 Hermetic 化

問題：redis-lock-edge-cases.test.mjs 和 redis-lock-optimized.test.mjs 預設需要 localhost:6379 Redis，無 Redis 時 CI fail/hang。

修復：加 SKIP_NO_REDIS guard，REDIS_URL 未設定時自動 skip。CI 需設定 REDIS_URL 環境變數才執行這些測試。

const SKIP_NO_REDIS = !process.env.REDIS_URL;
// ...
(SKIP_NO_REDIS ? describe.skip : describe)("Edge Case 1", () => { ... });

---

Fix #4：Redis lock key 包含 dbPath，恢復 per-db 隔離

問題：所有 dbPath 共用 "memory-write" 全域 key，完全抹除原本 per-db file lock 的隔離。

修復：key 改為 memory-write:{normalized_db_path}：

const redisLockKey = `memory-write:${normalizeStorageKey(this.config.dbPath)}`;

normalizeStorageKey() 會 resolve symlink 並把路徑正規化，確保同一 storage 的不同路徑表示得到相同的 key。

---

Fix #5：還原 memory-update-metadata-refresh.test.mjs 到 npm test

問題：PR 意外將該測試從 npm test 移除。

修復：將 node test/memory-update-metadata-refresh.test.mjs 放回正確位置（在 temporal-awareness 和 redis-lock-edge-cases 之間）。

---

測試驗證

# 無 REDIS_URL → Redis 測試自動 skip
npm test  # should pass (redis tests skipped)

# 有 Redis → 完整執行
REDIS_URL=redis://localhost:6379 npm test

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6407cf10bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Resolve normalizeStorageKey at module scope

runWithFileLock calls normalizeStorageKey(...) here, but the helper was inserted inside validateStoragePath (after an early return) rather than at module scope. That makes this identifier undefined in the class method scope, so write operations that reach this path will throw ReferenceError: normalizeStorageKey is not defined before any lock is acquired.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Restore MemoryStore.count used by tool retry paths

This change removes MemoryStore.count(), but src/tools.ts still passes context.store.count() into retrieveWithRetry (e.g. lines 219/584/1088/1230/2184). When an initial retrieval returns no rows, that callback is executed and will now throw TypeError: ...count is not a function, breaking those tool flows instead of performing the intended empty-store check and retry behavior.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Stop falling back after Redis lock acquisition timeouts

The fallback branch triggers for any acquire error before lockAcquired is set, including contention timeouts thrown by RedisLockManager.acquire. In that scenario, one writer can still hold the Redis lock while another proceeds under the file-lock fallback, so concurrent writes run under different lock domains and can race. Fallback should be limited to Redis-unavailable/init failures, not timeout/contended acquisition errors.

Useful? React with 👍 / 👎.