Bump dependencies and fix proxy generator circular imports#2201
Merged
einari merged 2 commits intoMay 12, 2026
Conversation
- Cratis.Chronicle* 15.22.13 → 15.25.5 - MongoDB.Driver 3.8.0 → 3.8.1 - SharpCompress 0.48.0 → 1.0.0 - Meziantou.Analyzer 3.0.70 → 3.0.78 - Microsoft.ClearScript.V8* 7.5.0 → 7.5.1 - @cratis/fundamentals ^7.7.3 → ^7.9.2
The previous approach emitted a derivatives list on each property descriptor and then tried to filter out types that were subtypes of the type being generated. This was fragile — it required post-processing the list and still left open edge cases. The correct fix is simpler: do not emit derivatives at all. The TypeScript @derivedType decorator registers each subtype with all its ancestors at decoration time, so JsonSerializer discovers subtypes via DerivedType.getDerivedTypesFor() without any explicit import list. Emitting derivatives would force the parent type to import each subtype, which creates circular dependencies whenever those subtypes extend the parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
@derivedTypedecorator handles subtype registration at decoration time, making the explicit list unnecessary.Changed