Consolidate PRs #2229, #2230, and #2232#2233
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/Cratis/Arc/sessions/14babc5a-7987-411f-add8-ea098bf25257 Co-authored-by: einari <134365+einari@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Cratis/Arc/sessions/ad2aa68a-002d-4784-bed2-9e113d3e2521 Co-authored-by: einari <134365+einari@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Cratis/Arc/sessions/f582b1f9-56c5-45aa-a028-5e0491cea41f Co-authored-by: einari <134365+einari@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Cratis/Arc/sessions/0986ad34-f238-4e47-9e6f-ea7a46a3c2a6 Co-authored-by: einari <134365+einari@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Cratis/Arc/sessions/e376f340-4a88-4c3e-818e-b5ac84bffbde Co-authored-by: einari <134365+einari@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Cratis/Arc/sessions/04ff52a7-0d6c-4320-84ea-ab8d0c7e1364 Co-authored-by: einari <134365+einari@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Cratis/Arc/sessions/d20d73f2-0a2f-4df2-a8be-38bc97ede375 Co-authored-by: einari <134365+einari@users.noreply.github.com>
Co-authored-by: einari <134365+einari@users.noreply.github.com>
# Conflicts: # Source/JavaScript/Arc.React/queries/for_useChangeStream/when_hook_is_disabled.ts # Source/JavaScript/Arc.React/queries/for_useChangeStream/when_receiving_first_update.ts # Source/JavaScript/Arc.React/queries/for_useChangeStream/when_receiving_second_update_with_key_based_delta.ts # Source/JavaScript/Arc.React/queries/for_useChangeStream/when_receiving_second_update_with_removed_item.ts # Source/JavaScript/Arc.React/queries/for_useChangeStream/when_receiving_second_update_with_server_change_set.ts # Source/JavaScript/Arc.React/queries/for_useChangeStream/when_receiving_update_in_full_transfer_mode/and_first_update_arrives.ts # Source/JavaScript/Arc.React/queries/for_useChangeStream/when_receiving_update_in_full_transfer_mode/and_subsequent_update_arrives.ts Co-authored-by: einari <134365+einari@users.noreply.github.com>
Co-authored-by: einari <134365+einari@users.noreply.github.com>
Co-authored-by: einari <134365+einari@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
einari
May 21, 2026 14:51
View session
|
NuGet packages for this PR, e.g. Cratis.Arc: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the work from #2229, #2230, and #2232 into a single reviewable PR covering typed radio CommandForm fields, command hook/version API corrections with test stabilization, and scoped messenger hierarchy support across Core, Arc.React, and Arc.React.MVVM.
Added
CommandFormradio fields (RadioButtonField,RadioGroupField) with docs, stories, typecheck coverage, and field behavior specs (Add Radio button / Radio button groups as command fields #2228).use()registration insideCommandScope(useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227)@cratis/arc/messaging, React messenger scope APIs, and scoped messaging docs/specs across Core/React/MVVM (Scoping Messenger #2231)Changed
CommandForm/generated command usage so the internal command version stays insideCommandFormwhile public.use()hooks align to the 3-tupleuseCommandAPI (useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227)Fixed
useChangeStream/command-related specs caused by shared test state and render-phase update warnings (useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227)Removed
useCommandtuple and generated command hook signatures (useCommand calls context.addCommand during render, causing React "Cannot update a component while rendering" warning #2227)