Add tracing, analyzer coverage, identity schema introspection, and EF JSON converter support by Copilot · Pull Request #2244 · Cratis/Arc

Copilot · 2026-05-23T17:57:42Z

Summary

Consolidates tracing, analyzer, introspection, and EF JSON serialization work into one change set. The result is better observability, stricter command-model validation, runtime schema discovery for identity details, and configurable JSON conversion for EF [Json] properties.

Added

Added tracing spans for Arc command, query, filter, action-filter, and identity resolution flows (Traces for Commands, Queries ++ #2242)
Added AddCratisArcActivitySource() registration through Arc core startup (Traces for Commands, Queries ++ #2242)
Added ARC0003 and ARC0004 analyzer rules with specs and documentation (Roslyn Analyzer: Arc Command Model Compliance (CHR-A016..A022, CHR-A026..A028) #2237)
Added GET /.cratis/identity-details/schema for runtime identity-details schema introspection (Introspection endpoint for knowing how identity type looks like #2240)
Added JsonConversionOptions and EntityFrameworkCoreOptions.JsonConverters for custom EF Core [Json] converters

Changed

Reorganized command analyzer specs by diagnostic rule and aligned command examples on record-based commands (Roslyn Analyzer: Arc Command Model Compliance (CHR-A016..A022, CHR-A026..A028) #2237)
Updated introspection docs and endpoint mapping to include identity-details schema (Introspection endpoint for knowing how identity type looks like #2240)
Replaced fixed EF JSON serializer usage with configurable serializer options
Updated proxy-generator spec bootstrap module resolution for rxjs and Arc messaging modules

arcBuilder.WithEntityFrameworkCore(options =>
{
    options.JsonConverters.Add(new MyRequestConverter(jobTypes));
});

Fixed

Fixed EF Core [Json] properties so interface-typed and custom-converted values round-trip correctly
Fixed missing analyzer coverage for misplaced command handlers and commands without a public Handle() method (Roslyn Analyzer: Arc Command Model Compliance (CHR-A016..A022, CHR-A026..A028) #2237)
Fixed identity introspection so clients can discover the runtime shape of identity details (Introspection endpoint for knowing how identity type looks like #2240)
Fixed spec fixtures to supply the new tracing dependencies introduced by the consolidated changes

…ces) can be used with [Json] properties - Add JsonConversionOptions with all Arc default converters (EnumConverterFactory, EnumerableConceptAsJsonConverterFactory, ConceptAsJsonConverterFactory, DateOnlyJsonConverter, TimeOnlyJsonConverter, TypeJsonConverter, UriJsonConverter, EnumerableModelWithIdToConceptOrPrimitiveEnumerableConverterFactory) - Add EntityFrameworkCoreOptions.JsonConverters list for user-supplied converters - Register JsonConversionOptions as singleton in DI from WithEntityFrameworkCore - Thread JsonConversionOptions through both ApplyJsonConversion overloads (optional param) - Update BaseDbContext to resolve JsonConversionOptions from ApplicationServiceProvider - Change JsonValueConverter<T>/JsonValueComparer<T> to accept JsonSerializerOptions via ctor - Add specs: for_JsonConversionOptions and when_applying_json_conversion_with_custom_options

…istration

… IDisposable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

…ix proxy messaging module

…to copilot/consolidate-pull-requests

…compliance' into copilot/consolidate-pull-requests

…nt' into copilot/consolidate-pull-requests # Conflicts: # Source/DotNET/Tools/ProxyGenerator.Specs/Scenarios/Infrastructure/arc-bootstrap.js

…als-add-traces' into copilot/consolidate-pull-requests

github-actions · 2026-05-24T07:19:26Z

NuGet packages for this PR, e.g. Cratis.Arc:
https://github.com/cratis/arc/packages/1655206?version=20.26.16

einari · 2026-05-24T07:31:12Z

@copilot Lets update all dependencies (except for those locked to preview versions)

Copilot · 2026-05-24T07:47:43Z

@copilot Lets update all dependencies (except for those locked to preview versions)

Addressed in 5c8f78f. I updated the stable JavaScript dependencies without touching preview-tagged versions, kept the local @cratis/* package references pinned, and added the missing test-app Vite aliases needed by the newer bundler resolution. Validation: yarn ci passed, yarn workspace @testapps/arccore build passed, and direct Vite production builds passed for both test apps. yarn workspace @testapps/aspnetcore build still hits the pre-existing Features/MongoWatcher/MongoWatcher.ts duplicate-identifier TypeScript errors that were already present before this change.

github-actions · 2026-05-24T08:33:30Z

NuGet packages for this PR, e.g. Cratis.Arc:
https://github.com/cratis/arc/packages/1655206?version=20.26.17-pr2244.5c8f78f

einari · 2026-05-24T10:12:25Z

@copilot Merge from main and then update all package dependencies

…ull-requests

Copilot · 2026-05-24T10:29:48Z

@copilot Merge from main and then update all package dependencies

Addressed in 8bc4138. I merged the latest main into this branch, then re-checked the package.json dependencies with npm-check-updates (keeping the local @cratis/* references pinned); they were already at the latest stable versions, so there were no further package-file updates to make. Validation: yarn workspace @cratis/arc.react ci and yarn workspace @testapps/arccore build passed. yarn workspace @testapps/aspnetcore build still hits the existing Features/MongoWatcher/MongoWatcher.ts duplicate-identifier errors.

github-actions · 2026-05-24T12:54:19Z

NuGet packages for this PR, e.g. Cratis.Arc:
https://github.com/cratis/arc/packages/1655206?version=20.26.17-pr2244.8bc4138

einari · 2026-05-24T13:39:54Z

@copilot Update the .NET packages to the latest - except those that are set to pre-release versions

Copilot · 2026-05-24T13:52:45Z

@copilot Update the .NET packages to the latest - except those that are set to pre-release versions

Addressed in d06e6d7. I updated the stable .NET package pins across the central package props, kept the existing prerelease pin intact, and left the net8/net9 EF/Npgsql/Mvc.Testing lines on their latest compatible stable versions because the 10.x packages only support net10.0. Validation: dotnet build Source/DotNET/EntityFrameworkCore/EntityFrameworkCore.csproj --configuration Release --no-restore, dotnet build Source/DotNET/Tools/ProxyGenerator.Build/ProxyGenerator.Build.csproj --configuration Release --no-restore, dotnet build Source/DotNET/Tools/ProxyGenerator.Specs/ProxyGenerator.Specs.csproj --configuration Release --no-restore, dotnet test Source/DotNET/Chronicle.Specs/Chronicle.Specs.csproj --configuration Release --no-build --no-restore, and dotnet test Source/DotNET/Arc.Specs/Arc.Specs.csproj --configuration Release --no-build --no-restore.

github-actions · 2026-05-24T14:46:07Z

NuGet packages for this PR, e.g. Cratis.Arc:
https://github.com/cratis/arc/packages/1655206?version=20.26.17-pr2244.d06e6d7

einari · 2026-05-24T15:18:25Z

@copilot Look at the following PR for how we've done the registration of library ActivitySources with the generic solution:

https://github.com/Cratis/Chronicle/pull/3318/changes#diff-c2d5b225afa1fb687b7464426f7aa143f2dee181baad44eb166209ab3f6cbd4a

Copilot · 2026-05-24T15:29:52Z

@copilot Look at the following PR for how we've done the registration of library ActivitySources with the generic solution:

https://github.com/Cratis/Chronicle/pull/3318/changes#diff-c2d5b225afa1f...

Addressed in f79461e. I changed Arc to follow the Chronicle pattern: register one shared Cratis.Arc ActivitySource, then register explicit typed IActivitySource<T> wrappers for the Arc core pipeline types and the ASP.NET action filters instead of the blanket open-generic registration. Validation: dotnet test Source/DotNET/Arc.Core.Specs/Arc.Core.Specs.csproj --configuration Release --no-restore --no-build and dotnet test Source/DotNET/Arc.Specs/Arc.Specs.csproj --configuration Release --no-restore --no-build both passed.

github-actions · 2026-05-24T15:31:16Z

NuGet packages for this PR, e.g. Cratis.Arc:
https://github.com/cratis/arc/packages/1655206?version=20.26.19

+    internal static IServiceCollection AddActivitySource(this IServiceCollection services, string sourceName)
+    {
+#pragma warning disable CA2000 // Dispose objects before losing scope
+        services.TryAddKeyedSingleton(sourceName, new DiagnosticsActivitySource(sourceName));


Copilot AI and others added 29 commits May 22, 2026 08:46

Initial plan

638423d

docs(efcore): document JsonConversionOptions and custom converter reg…

b409a83

…istration

fix(proxy-specs): add rxjs to arc-bootstrap.js module path map

fb8626a

Initial plan

fa70baa

Add ARC0003 and ARC0004 command analyzers

e26ea56

Clarify analyzer diagnostic fix guidance

263575c

Initial plan

da290da

Add identity details schema introspection endpoint

37581ac

Rename identity schema introspection route

6b341f7

Document identity details schema introspection endpoint

8cc94af

Use record command examples in analyzer docs and specs

2a453c1

Initial plan

b1baca7

Add distributed traces for Commands, Queries, Filters, and Identity

c0cb1d4

Potential fix for pull request finding 'Missing Dispose call on local…

fea6f70

… IDisposable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Missing Dispose call on local…

2d76459

… IDisposable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Missing Dispose call on local…

59eb971

… IDisposable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Missing Dispose call on local…

0f0f38d

… IDisposable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Missing Dispose call on local…

73de02e

… IDisposable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Fix proxy-spec module resolution regressions

f3b5bc9

Organize command analyzer specs per ARC rule

b9bbd3d

fix(efcore): primary constructor + DerivedTypeJsonConverterFactory; f…

e74d1cc

…ix proxy messaging module

Prefix all [Span] names with cratis. so they start with cratis.arc.*

3261709

Merge remote-tracking branch 'origin/copilot/improve-json-support' in…

73e60c3

…to copilot/consolidate-pull-requests

Merge remote-tracking branch 'origin/copilot/add-roslyn-analyzer-arc-…

2fd0add

…compliance' into copilot/consolidate-pull-requests

Merge remote-tracking branch 'origin/copilot/add-introspection-endpoi…

dfffde2

…nt' into copilot/consolidate-pull-requests # Conflicts: # Source/DotNET/Tools/ProxyGenerator.Specs/Scenarios/Infrastructure/arc-bootstrap.js

Merge remote-tracking branch 'origin/copilot/upgrade-cratis-fundament…

32c9ad8

…als-add-traces' into copilot/consolidate-pull-requests

Fix tracing spec fixtures

60532e6

Fix spec using order

372e19b

Copilot AI self-assigned this May 23, 2026

Merge branch 'main' into copilot/consolidate-pull-requests

305b6c1

Copilot started work on behalf of einari May 24, 2026 07:31 View session

chore: update stable javascript dependencies

5c8f78f

Copilot finished work on behalf of einari May 24, 2026 07:48

Copilot started work on behalf of einari May 24, 2026 10:12 View session

Merge remote-tracking branch 'origin/main' into copilot/consolidate-p…

8bc4138

…ull-requests

Copilot finished work on behalf of einari May 24, 2026 10:30

Copilot started work on behalf of einari May 24, 2026 13:40 View session

chore: update stable dotnet package versions

d06e6d7

Copilot finished work on behalf of einari May 24, 2026 13:53

Copilot started work on behalf of einari May 24, 2026 15:18 View session

Align Arc activity source registration with shared library pattern

f79461e

Copilot finished work on behalf of einari May 24, 2026 15:30

github-code-quality Bot found potential problems May 24, 2026

View reviewed changes

einari marked this pull request as ready for review May 25, 2026 11:01

einari merged commit a2a9798 into main May 25, 2026
53 checks passed

einari deleted the copilot/consolidate-pull-requests branch May 25, 2026 11:01

Conversation

Copilot AI commented May 23, 2026 • edited by einari Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Added

Changed

Fixed

Uh oh!

github-actions Bot commented May 24, 2026

Uh oh!

einari commented May 24, 2026

Uh oh!

Copilot AI commented May 24, 2026

Uh oh!

github-actions Bot commented May 24, 2026

Uh oh!

einari commented May 24, 2026

Uh oh!

Copilot AI commented May 24, 2026

Uh oh!

github-actions Bot commented May 24, 2026

Uh oh!

einari commented May 24, 2026

Uh oh!

Copilot AI commented May 24, 2026

Uh oh!

github-actions Bot commented May 24, 2026

Uh oh!

einari commented May 24, 2026

Uh oh!

Copilot AI commented May 24, 2026

Uh oh!

github-actions Bot commented May 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented May 23, 2026 •

edited by einari

Loading