Add useOnMessage and useSendMessage React messenger hooks#2252
Merged
Conversation
Expose two new hooks around MessengerScopeContext so components can subscribe to and publish typed messages without holding a reference to the messenger. useOnMessage takes a message constructor, a callback, and an optional filter that receives the actual typed message and decides whether the consumer is interested. The callback and filter are kept in refs so neither needs to be memoized, and the subscription is cleaned up on unmount. useSendMessage returns a stable, bound publish function.
Cover the BDD scenarios for both hooks: matching publish, non-matching type, filter acceptance and rejection, unmount cleanup, callback changes without re-subscribing, scope trickle-down, and stable publish function reference across renders.
Add Subscribing and Publishing sections covering the new hooks, including the optional filter on useOnMessage that narrows on message content without re-subscribing.
|
NuGet packages for this PR, e.g. Cratis.Arc: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
useOnMessageReact hook that subscribes to messages of a given type from the nearestMessengerScope, with an optional filter predicate that receives the typed message and decides whether the consumer is interested.useSendMessageReact hook that returns a stable function for publishing messages to the nearestMessengerScope.