Remove browser CustomEvent publishing from ObservableQueryDiagnostics#2261
Closed
Copilot wants to merge 2 commits into
Closed
Remove browser CustomEvent publishing from ObservableQueryDiagnostics#2261Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix ObservableQueryDiagnostics crash on React Native / Hermes
Remove browser CustomEvent publishing from ObservableQueryDiagnostics
May 28, 2026
|
NuGet packages for this PR, e.g. Cratis.Arc: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ObservableQueryDiagnosticswas publishing a browserCustomEventon every snapshot, which crashes on React Native/Hermes whereCustomEventis not available. This change removes that browser event path and keeps diagnostics transport purely API-based.Added
Changed
ObservableQueryDiagnostics._publishSnapshot()to emit snapshots only viasnapshots$(ObservableQueryDiagnostics crashes on React Native / Hermes due to missing CustomEvent #2260)getSnapshot()andsnapshots$, notwindowevents (ObservableQueryDiagnostics crashes on React Native / Hermes due to missing CustomEvent #2260)Fixed
new CustomEvent(...)during diagnostics publication (ObservableQueryDiagnostics crashes on React Native / Hermes due to missing CustomEvent #2260)Removed
window.dispatchEvent(new CustomEvent('cratis:observable-query-diagnostics', ...))from diagnostics publishing (ObservableQueryDiagnostics crashes on React Native / Hermes due to missing CustomEvent #2260)Security
Deprecated