feat(DEV-144): completed by Prabal-buzz · Pull Request #179 · CravingsInc/CravingsBackend

Prabal-buzz · 2025-08-30T03:04:19Z

Implement createReviewCampaign mutation.

Copilot

Pull Request Overview

This PR implements a complete review campaign system that allows event organizers to create custom review forms and collect feedback from attendees. The implementation includes GraphQL resolvers, TypeORM models, input types, and database migrations for the entire review workflow.

Complete review campaign functionality with CRUD operations for campaigns, questions, and reviews
Support for multiple question types (text, range, dropdown) with configurable options
Authentication middleware and proper context typing for GraphQL operations

Reviewed Changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/types/MyContext.ts	Defines GraphQL context interface with Express request/response and session
src/resolvers/index.ts	Exports the new ReviewResolver
src/resolvers/ReviewResolver.ts	Main resolver with all CRUD operations for review campaigns, questions, and reviews
src/models/types/reviews/	Input type definitions for GraphQL mutations and queries
src/models/reviews/	TypeORM entity models for the review system database schema
src/migration/1700000000000-CreateReviewTables.ts	Database migration to create all review-related tables
src/middleware/isAuth.ts	Authentication middleware for protected mutations

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-02T15:05:11Z

src/resolvers/ReviewResolver.ts

+    // Review Campaign Mutations
+    @Mutation(() => CreateReviewCampaignPayload)
+    @UseMiddleware(isAuth)
+    async createReviewCampaign(@Arg("input") input: CreateReviewCampaignInput, @Ctx() { req }: any) {


The context parameter should be properly typed using the MyContext interface instead of any to maintain type safety.

Copilot · 2025-09-02T15:05:11Z

src/models/reviews/ReviewAnswer.ts

+
+    @CreateDateColumn()
+    @Field()
+    createAt: Date;


Property name should be createdAt to be consistent with other entities and standard naming conventions.

Suggested change

createAt: Date;

createdAt: Date;

Copilot · 2025-09-02T15:05:12Z

src/migration/1700000000000-CreateReviewTables.ts

+                        isNullable: true
+                    },
+                    {
+                        name: "createAt",


Column name should be createdAt to match the entity definition and standard naming conventions.

Suggested change

name: "createAt",

name: "createdAt",

Copilot · 2025-09-02T15:05:12Z

src/models/reviews/README.md

+**Fields:**
+
+- `id`: Unique identifier (UUID)
+- `name`: Campaign name


The documentation refers to a name field, but the actual entity uses title. This should be corrected to match the implementation.

Suggested change

- `name`: Campaign name

- `title`: Campaign title

Copilot · 2025-09-02T15:05:12Z

src/models/reviews/README.md

+- `textAnswer`: Text answer (for text questions)
+- `rangeAnswer`: Numeric answer (for range questions)
+- `dropDownAnswer`: Selected dropdown option (for dropdown questions)
+- `createAt`: Creation timestamp


Field name should be createdAt to match the entity definition and standard naming conventions.

Suggested change

- `createAt`: Creation timestamp

- `createdAt`: Creation timestamp

Copilot · 2025-09-02T15:05:13Z

src/models/reviews/README.md

+const campaign = await ReviewCampaign.create({
+  name: "Event Feedback 2024",


The example code uses name property, but the actual entity uses title. This should be corrected to match the implementation.

codingwithcn

Left changes

codingwithcn · 2025-09-02T15:14:39Z

src/middleware/isAuth.ts

I see what your trying to do with this isAuth, but this implementation won't work, for two reason, in session_token is only savedd user side not on backend side. Second reason the session_token that is saved on client side, is a hashed token so we won't be able to have session.userId.

and also a user can have a session.userId, but we still need to verify what ever token is given. Please do not use this middleware as it doesn't work. Or modify it, in a way that does work. To figure what to see if it works or not, check other examples of how we logged user in, and verified their token.

codingwithcn · 2025-09-02T15:16:32Z

src/migration/1700000000000-CreateReviewTables.ts

This is honestly no point of being here, as typeorm will naturally create your tables for you. And the migration-scripts for future reference are here not for migration but to allow for synchronizing testing across different development environments.

So please remove this

codingwithcn · 2025-09-02T15:19:53Z

src/models/reviews/DropDown.ts

+    @Field()
+    @Column()
+    text: string;
+


add this for proper type handling

@Field() @Column() dataType: "string" | "number"; // This allows us to make sure when we are registering, rendering on client or server side it is being handled properly

codingwithcn · 2025-09-02T15:23:01Z

src/models/reviews/Review.ts

+
+    @ManyToOne("ReviewCampaign", (reviewCampaign: any) => reviewCampaign.reviews, { onDelete: "CASCADE" })
+    @JoinColumn()
+    reviewCampaign: any;


This should not be type any, and don't put it in string. Instead have it be ReviewCampaign. This is a typescript backend, using type any ruins the whole point of choosing typescript for the backend

codingwithcn · 2025-09-02T15:25:27Z

src/models/reviews/ReviewAnswer.ts

+    @Field(() => DropDown, { nullable: true })
+    @ManyToOne(() => DropDown, { nullable: true, onDelete: "SET NULL" })
+    @JoinColumn()
+    dropDownAnswer: DropDown | null;


You have to provide a reference for dropDownAnswer to DropDown. This will return backend errors. And if the dropDown should delete then the Review Answer should be deleted as well

codingwithcn · 2025-09-02T15:34:20Z

src/resolvers/ReviewResolver.ts

+
+    // Review Mutations
+    @Mutation(() => Review)
+    async submitReview(@Arg("input") input: SubmitReviewInput) {


review needs to be associated to either people that bought ticket_id, or people registration list

codingwithcn · 2025-09-02T15:34:38Z

src/resolvers/ReviewResolver.ts

+    }
+
+    @Mutation(() => Review)
+    async updateReview(@Arg("input") input: UpdateReviewInput) {


review needs to be associated to either people that bought ticket_id, or people registration list

codingwithcn · 2025-09-02T15:35:05Z

src/resolvers/ReviewResolver.ts

+    }
+
+    // Review Queries
+    @Query(() => [Review])


Before you can send review_campaign you need to verify user is logged in and authenticated. And your sending them the right review, and not sending them the wrong thing

codingwithcn · 2025-09-02T15:35:11Z

src/resolvers/ReviewResolver.ts

+        });
+    }
+
+    @Query(() => Review, { nullable: true })


Before you can send review_campaign you need to verify user is logged in and authenticated. And your sending them the right review, and not sending them the wrong thing

codingwithcn · 2025-09-02T15:35:31Z

src/types/MyContext.ts

delete this, or right better context

Prabal-buzz added 2 commits August 27, 2025 18:41

feat(DEV-143): completed

b785d18

feat(DEV-144): completed

2bfe127

Prabal-buzz requested a review from codingwithcn August 30, 2025 03:04

codingwithcn changed the base branch from DEV-143 to DEV-126 September 2, 2025 15:03

codingwithcn requested a review from Copilot September 2, 2025 15:03

Copilot AI reviewed Sep 2, 2025

View reviewed changes

codingwithcn requested changes Sep 2, 2025

View reviewed changes

feat(DEV-144): fixed code review changes

013d10d

Prabal-buzz requested a review from codingwithcn October 4, 2025 12:21

	- `createAt`: Creation timestamp
	- `createdAt`: Creation timestamp

		const campaign = await ReviewCampaign.create({
		name: "Event Feedback 2024",

Conversation

Prabal-buzz commented Aug 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

codingwithcn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants