[pull] main from ghostty-org:main#696
Merged
pull[bot] merged 10 commits intoCrazyForks:mainfrom Apr 21, 2026
Merged
Conversation
The GhosttyKit xcframework previously shipped the entire include/ directory, which pulled in the libghostty-vt headers under include/ghostty/. Because those headers are not referenced from the ghostty.h umbrella, Clang's module system emitted "umbrella header for module 'GhosttyKit' does not include header 'ghostty/vt/*.h'" warnings in Xcode builds. Stage only ghostty.h and module.modulemap via addWriteFiles so the xcframework Headers directory contains exactly the GhosttyKit API, mirroring the pattern used in GhosttyLibVt.xcframework. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Triggered by [discussion comment](https://github.com/ghostty-org/ghostty/discussions/12361#discussioncomment-16656763) from @jcollie. Vouch: @sandydoo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…2360) The GhosttyKit xcframework previously shipped the entire include/ directory, which pulled in the libghostty-vt headers under include/ghostty/. Because those headers are not referenced from the ghostty.h umbrella, Clang's module system emitted "umbrella header for module 'GhosttyKit' does not include header 'ghostty/vt/*.h'" warnings in Xcode builds. Stage only ghostty.h and module.modulemap via addWriteFiles so the xcframework Headers directory contains exactly the GhosttyKit API, mirroring the pattern used in GhosttyLibVt.xcframework. ## AI disclosure Claude made the changes (including the commit message), I reviewed and tested them.
I removed the entire paragraph in CONTRIBUTING.md because the "Quick Guide" section explains it all better already.
This helps developers like me to use a separate config for debugging (which is already supported by the environment variable `GHOSTTY_CONFIG_PATH`). I can already use the local scheme to load a debugging config file, but when opening the config file through Ghostty, it will still open the default config. This changes doesn't affect the release build, since `configPath` is only set in the DEBUG build.
This updates our Nix flake to use the Homebrew bottled Zig 0.15.2 which contains a patch to work around the issue with Zig 0.15.x and Xcode 26.4.
This updates our Nix flake to use the Homebrew bottled Zig 0.15.2 which contains a patch to work around the issue with Zig 0.15.x and Xcode 26.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )