feat(grpc): per-method timeout budgets and inbound deadline propagation#658
Open
Bolajiomo99 wants to merge 5 commits into
Open
feat(grpc): per-method timeout budgets and inbound deadline propagation#658Bolajiomo99 wants to merge 5 commits into
Bolajiomo99 wants to merge 5 commits into
Conversation
Composes caller-remaining and configured budgets in sdk/grpc/client.ts and emits DEADLINE_EXCEEDED metrics.
|
@Bolajiomo99 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…eoutCredenceError constructor call - Replaced forever-pending mock next with signal-aware version in timeout tests - Fixed SdkRequestTimeoutCredenceError cause passed as status instead of options - Removed unused afterEach import
- Add missing @connectrpc packages to dependencies (package.json) - Add AuditAction mock export in replayService.test.ts - Expand openapi-drift.js route list to match generate-openapi.ts - Wrap MockConnectError in vi.hoisted() for vitest v4 compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composes caller-remaining and configured budgets in sdk/grpc/client.ts and emits DEADLINE_EXCEEDED metrics.
Closes #632
Description
This pull request adds configurable per-method timeout budgets and propagates inbound deadline information to internal gRPC calls, preventing cascading stalls from hung upstreams. The deadline composition follows a monotonic chain from the edge inward.
Previously, createCredenceGrpcClient issued calls without an explicit per-method deadline, so a hung upstream could block a caller indefinitely and there was no incoming-deadline propagation when a gRPC call was made on behalf of an HTTP request.
Changes Made
Closes #632
Type of Change
Verification & Test Plan
Automated Tests
npm test
npm run lint
npm run build
Manual Verification
Notes
Checklist