#409 Tighten Lighthouse perf budgets in CI FIXED#454
Merged
Baskarayelu merged 1 commit intoJun 29, 2026
Merged
Conversation
Contributor
Author
|
@Baskarayelu |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings
The project uses a React + TypeScript + Vite stack with Vitest for testing.
The dashboard route is located at:
src/pages/Dashboard.tsxExisting test coverage:
src/pages/Dashboard.test.tsxThe repository contains pre-existing unrelated failing tests, so the full suite is not currently passing.
Identified Issue
The Dashboard page lacked a regression-style test enforcing a strict rendering contract.
No safeguard existed to ensure the structure of the main connected dashboard view remains consistent.
Risk:
Fix Implemented
Added a new test file:
src/pages/Dashboard.performance.test.tsxFix Features
1. Happy Path Coverage
Confirms the connected dashboard renders exactly 4 main action-card regions:
2. Sad Path Coverage
Ensures disconnected users:
Why This Helps
Validation Result
Final Outcome
CLOSE #409