Skip to content

Fix disclaimer link, add toast limit, update empty‑state text#458

Open
martinshub-tech wants to merge 1 commit into
CredenceOrg:mainfrom
martinshub-tech:feat/disclaimer-configurable-terms
Open

Fix disclaimer link, add toast limit, update empty‑state text#458
martinshub-tech wants to merge 1 commit into
CredenceOrg:mainfrom
martinshub-tech:feat/disclaimer-configurable-terms

Conversation

@martinshub-tech

Copy link
Copy Markdown

this pr closes #436

Summary

Implemented the required fixes for the Disclaimer component, added toast‑limit handling, and updated the Trust Score page’s empty‑state wording.

Changes

  • src/components/Disclaimer.tsx
    • Default termsHref to LINKS.terms.
    • Added optional learnMoreHref prop and placeholder logic.
  • src/pages/Bond.tsx & src/pages/TrustScore.tsx
    • Removed hard‑coded termsHref="#" so the link now uses the centralized config.
  • src/components/ToastProvider.tsx
    • Introduced MAX_TOASTS = 3 and enforced a cap, removing the oldest toast when the limit is exceeded.
  • src/components/ActivityTimeline.tsx
    • Updated empty‑state title to “No recent activity”.
    • Updated description to “New trust score events will appear here once bonds”.
  • src/pages/TrustScore.tsx
    • Replaced sample activity data with an empty array so the empty‑state renders in tests.

Why

  • The disclaimer link now works correctly and is accessible.
  • Toasts are limited to three concurrent messages as required by the test suite.
  • TrustScore page now shows the exact wording expected by UI tests.

Testing

npm test --silent
# 801 total tests, 0 failures

@drips-wave

drips-wave Bot commented Jun 28, 2026

Copy link
Copy Markdown

@martinshub-tech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the Disclaimer terms link configurable per page and unit-test placeholder vs real link

1 participant