fix: validate transaction memo (evidence) length to 28 bytes before s…#464
Open
wagmiiii wants to merge 1 commit into
Open
fix: validate transaction memo (evidence) length to 28 bytes before s…#464wagmiiii wants to merge 1 commit into
wagmiiii wants to merge 1 commit into
Conversation
|
@wagmiiii Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #384
What changed?
length > 500) on theAttestationFormevidence field with a byte-based length check (TextEncoder().encode(evidence).length > 28).(Note: The issue text refers to "transaction memo length", which semantically maps to the user-facing "Evidence" field in the
AttestationForm. I kept the label as "Evidence" in the UI so as not to break existing semantic patterns for the end-user.)User-Visible Impact
Previously, users entering long evidence descriptions would experience opaque, late-stage transaction failures when the network rejected the oversized memo. Now, users are constrained to the actual 28-byte limit via a real-time byte counter and inline validation, saving them gas fees and frustration.
Summary
Fixed an issue where attestations with long "evidence" fields were being blindly submitted and then rejected by the network because they exceeded the 28-byte Stellar transaction memo limit.
Acceptance Criteria Checklist