feat: add standardized useActionToast hook for irreversible actions#466
Open
wagmiiii wants to merge 1 commit into
Open
feat: add standardized useActionToast hook for irreversible actions#466wagmiiii wants to merge 1 commit into
wagmiiii wants to merge 1 commit into
Conversation
|
@wagmiiii Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #379
Summary
Added a centralized standard for displaying success and failure toasts during irreversible actions (
sign,send,approve, anddelete).What changed
src/config/toastMessages.ts: Landed the notification string constants in a single place to ensure consistency across the application.src/hooks/useActionToast.ts: Added a new hook that wraps promises for these specific actions. It automatically unwraps the success result to fire a success toast, or catches failures to fire a danger toast before re-throwing the error so local UI state can be managed correctly.docs/STATE_MANAGEMENT.md: Updated the Toast behavior guide to direct developers to use this hook instead of manualaddToastcalls for irreversible actions.(Note: Because the UI features for these specific actions haven't been implemented yet, this PR focuses on fulfilling the issue's requirements at the infrastructure level so that they can be reused everywhere once those features land without enforcing manual
try/catchworkarounds.)Acceptance Criteria Checklist
docs/STATE_MANAGEMENT.md).