Fix extraction completion logic failing due to undefined job#197
Open
alexculealt wants to merge 2 commits intomainfrom
Open
Fix extraction completion logic failing due to undefined job#197alexculealt wants to merge 2 commits intomainfrom
alexculealt wants to merge 2 commits intomainfrom
Conversation
* Fix broken URLs for extraction details * Fix linting issue
Member
|
@alexculealt Weird. Do we know what those jobs are? |
Collaborator
Author
@rsaksida, those were seen only once in my local environment which lead to an extraction staying at 100%, in progress instead of complete. I didn't follow up on which jobs they were but I am not surprised as my environment has been fairly unstable (restarting Postgress, Redis & workers - probably even while the jobs were being enqueued). The idea of the fix is to not crash if such a condition was to occur - but I'd be happy to keep the original code if we think a visible fail would be more useful to lead us to a potential root cause. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BullMQ can return entries of jobs with undefined data, skip processing those.