Easier extractions assesments by subsample selection & other small improvements#199
Open
alexculealt wants to merge 3 commits intofeat/pick-modelfrom
Open
Easier extractions assesments by subsample selection & other small improvements#199alexculealt wants to merge 3 commits intofeat/pick-modelfrom
alexculealt wants to merge 3 commits intofeat/pick-modelfrom
Conversation
alexculealt
force-pushed
the
feat/extraction-subsample
branch
from
674440e to
650b617
Compare
alexculealt
force-pushed
the
feat/extraction-subsample
branch
from
650b617 to
8fbf1e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements:
Fix simplified content breaking page UI due to line length
Currently due to using a <pre> element, the layout width of the extracted page detail screen is oversized to fit the longest text line. This makes the page get high horizontal scroll which makes it difficult to select a different tab and to reason about the screen. This fixes the issue by wrapping the text to fit normal layout sizes.
Add URL based state for the tab navigation of the crawl page detail screen
The crawl page detail screen tabs now rely on URL state to select displayed tab which allows for referencing a certain tab by the URL and builds on the actions introduced in the next commit.
Add sample tool to extractions
Ads a sample dialog box that allows inspecting a subsample of the extraction bringing together various views that are only currently do-able either via the database or after an extraction is completed. With the sampling tool, we can asses performance of large catalogues (3000 items) without waiting for the extraction to complete, without having to do DB queries which have their complications and without requiring manually corroborating data items (via dataset CSV exports) and their source pages. A short video below demoes this feature in action:
sample-extractions-smaller.mov