Don't show pagination bar if pagination-data is not emitted#59
Don't show pagination bar if pagination-data is not emitted#59BrockReece wants to merge 7 commits intomasterfrom
Conversation
|
What happens when the page size starts at 1 but becomes more than 1? will it render the show the pagination bar at that point? |
|
This doesn't care about the pagination data as such, it only cares about whether the datagrid component emits any pagination data. In your example above, the pagination data will still be emitted, even if it only has a single page of results, and the pagination bar will show and reflect this. A possible use case for this would be passing through a local dataset, the datagrid component will not emit pagination data in this case and so the pagination bar will not show. Does that make sense? |
|
Yep, it does thanks.. looks good so far. |
|
Test coverage added for this component and docs updated to include a local data use case with the pagination bar hidden. If we are happy with this I will show Product this afternoon. |
Updates to the datagrid wrapper component to only show the pagination bar if there is pagination data emitted from the the root datagrid component. As requested in https://github.com/CroudSupport/cc-vuejs-monorepo/pull/43
Can anyone see any issues with this?
I will need to pass this by product, update the docs and the tests before this gets merged in.
refs #58