-
Notifications
You must be signed in to change notification settings - Fork 725
chore(deps-dev): bump eslint from 8.57.0 to 9.26.0 #3797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.0 to 9.26.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/v9.26.0/CHANGELOG.md) - [Commits](eslint/eslint@v8.57.0...v9.26.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 9.26.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
2 similar comments
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
| "cross-env": "7.0.2", | ||
| "deep-object-diff": "^1.1.9", | ||
| "eslint": "^8.12.0", | ||
| "eslint": "^9.26.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint 9 requires @typescript-eslint v8, but v5/v6 remain
High Severity
Upgrading eslint from v8 to v9.26.0 without updating @typescript-eslint/eslint-plugin and @typescript-eslint/parser creates a peer dependency incompatibility. ESLint 9.x requires @typescript-eslint/* v8+, but the packages remain at v5.x (backend, services) and v6.x (github actions). This will cause linting to fail or behave incorrectly since the typescript-eslint packages don't support ESLint 9's APIs and flat config system.
Additional Locations (2)
| "cross-env": "7.0.2", | ||
| "deep-object-diff": "^1.1.9", | ||
| "eslint": "^8.12.0", | ||
| "eslint": "^9.26.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint 9 incompatible with eslint-config-airbnb packages
High Severity
The eslint-config-airbnb-base: ^15.0.0 and eslint-config-airbnb-typescript: ^16.1.4 packages do not support ESLint 9.x. These configs use the legacy eslintrc format and rules that are incompatible with ESLint 9's new configuration system. The Airbnb team has not released ESLint 9-compatible versions, so linting in the backend will fail even after addressing the @typescript-eslint incompatibility.
| "@typescript-eslint/eslint-plugin": "^5.59.2", | ||
| "@typescript-eslint/parser": "^5.59.2", | ||
| "eslint": "^8.39.0", | ||
| "eslint": "^9.26.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint 9 removes --ext CLI option used in service lint scripts
Medium Severity
The upgrade to eslint: ^9.26.0 in the services workspace will break lint scripts in multiple service apps (cache_worker, categorization_worker, cron_service, data_sink_worker, entity_merging_worker) that use npx eslint --ext .ts src. The --ext CLI option was removed in ESLint 9 and will cause an "Unknown option '--ext'" error when running lint commands. These apps don't have their own eslint dependency and rely on the workspace root version.
Bumps eslint from 8.57.0 to 9.26.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Changelog
Sourced from eslint's changelog.
... (truncated)
Commits
8bbabc49.26.016f5ff7Build: changelog update for 9.26.05b247c8chore: upgrade to@eslint/js@9.26.0(#19681)d6fa4acchore: package.json update for@eslint/jsreleasee9754e7feat: add reportGlobalThis to no-shadow-restricted-names (#19670)0fa2b7afeat: add suggestions foreqeqeqrule (#19640)dd98d63docs: Update README96e84defix: check cache file existence before deletion (#19648)c25e858docs: Update README0958690chore: disambiguate internal typesLanguageOptionsandRule(#19669)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Note
Medium Risk
Dev-tooling-only change, but it’s a major ESLint upgrade that can break lint/CI via rule behavior changes and stricter Node/peer dependency requirements.
Overview
Upgrades ESLint major version across the repo (GitHub Action
./.github/actions/node,backend, andservices) from v8 toeslint@9.26.0.Updates
pnpm-lock.yamlaccordingly, pulling in ESLint 9’s new dependency tree (notably@eslint/*packages and related transitive upgrades) and adjusting some resolved sources (e.g., theclearbit/needledependency resolution).Written by Cursor Bugbot for commit 375d408. This will update automatically on new commits. Configure here.