Migrate e2e tests to @crowdstrike/foundry-playwright#126
Merged
Conversation
mraible
force-pushed
the
foundry-playwright-integration
branch
from
371575c to
7d48a32
Compare
Replace local tarball reference with published npm package.
mraible
force-pushed
the
foundry-playwright-integration
branch
from
e6feff6 to
0c2e128
Compare
The library already provides verifyWorkflowExecutionCompleted(), so the local extension class is unnecessary.
Kept userPreferencesExtensionPage, collectionsCRUDExtensionPage, and workflowsPage which are used in tests. Removed FoundryHomePage, AppManagerPage, AppCatalogPage, appName, and config fixtures that were defined but never destructured.
javier-carrasco-crowdstrike
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate e2e tests from inline Playwright helpers to the shared
@crowdstrike/foundry-playwrightlibrary.This replaces duplicated auth, page object, and config code with the shared library that provides
defineFoundryConfig(),AppCatalogPage,WorkflowsPage,DetectionExtensionPage, and other page objects.Blocked on:
@crowdstrike/foundry-playwrightbeing published to npm. The dependency currently points to a local.tgzfile and must be updated to a version specifier before merging.