Skip to content

Fix iframe selector for Charlotte AI compatibility #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mraible merged 1 commit into from
Apr 8, 2026
Merged

Fix iframe selector for Charlotte AI compatibility #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/src/pages/HelloExtensionPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ export class HelloExtensionPage extends SocketNavigationPage {
}

// Verify iframe loads
await expect(this.page.locator('iframe')).toBeVisible({ timeout: 15000 });
await expect(this.page.locator('iframe[name="portal"]')).toBeVisible({ timeout: 15000 });
this.logger.info('Extension iframe loaded');

// Verify iframe content
const iframe: FrameLocator = this.page.frameLocator('iframe');
const iframe: FrameLocator = this.page.frameLocator('iframe[name="portal"]');

// Check for "Foundry Functions Demo" text
await expect(iframe.getByText(/Foundry Functions Demo/i)).toBeVisible({ timeout: 10000 });
Expand Down
Loading