Skip to content

Improve error handling in servicenow function #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mraible merged 3 commits into from
Jul 10, 2025
Merged

Improve error handling in servicenow function #9

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c5098c
Improve error handling in servicenow function
mraible Jul 10, 2025
b687ea1
Add comments
mraible Jul 10, 2025
11f65cc
Use different exception variable names
mraible Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions functions/servicenow/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,15 @@ def on_post(request: Request, config: Dict[str, object] | None, logger: Logger)
},
code=201 if response["status_code"] == 200 else response["status_code"]
)
except ValueError as v:
# ValueError can be thrown if one of the fields accessed in the response does not exist
logger.error(f"Error processing ServiceNow response: {str(v)}", exc_info=True)
return Response(
code=500,
errors=[APIError(code=500, message=f"Error creating incident: {str(v)}")]
)
except Exception as e:
# Catch-all for unexpected errors
logger.error(f"Error creating ServiceNow incident: {str(e)}", exc_info=True)
return Response(
code=500,
Expand Down