Skip to content

MPDX-9562: Fix PDS Goal Calculator issues #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dr-bizz merged 1 commit into from
May 21, 2026
+8 −8
Merged

MPDX-9562: Fix PDS Goal Calculator issues #1779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/components/HrTools/Shared/CalculationReports/DirectionButtons/DirectionButtons.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ describe('DirectionButtons', () => {
userEvent.hover(continueButton.parentElement!);

expect(
await findByText('Complete all required fields to continue'),
await findByText('Complete all fields to continue'),
).toBeInTheDocument();
});

Expand All @@ -161,7 +161,7 @@ describe('DirectionButtons', () => {

await waitFor(() => {
expect(
queryByText('Complete all required fields to continue'),
queryByText('Complete all fields to continue'),
).not.toBeInTheDocument();
});
});
Expand All @@ -170,7 +170,7 @@ describe('DirectionButtons', () => {
const { findByRole, findByText, queryByText } = render(
<TestComponent
disableNext={true}
disabledNextTooltip="Complete all required fields to submit"
disabledNextTooltip="Complete all fields to submit"
/>,
);

Expand All @@ -180,10 +180,10 @@ describe('DirectionButtons', () => {
userEvent.hover(continueButton.parentElement!);

expect(
await findByText('Complete all required fields to submit'),
await findByText('Complete all fields to submit'),
).toBeInTheDocument();
expect(
queryByText('Complete all required fields to continue'),
queryByText('Complete all fields to continue'),
).not.toBeInTheDocument();
});

Expand All @@ -207,7 +207,7 @@ describe('DirectionButtons', () => {
const { findByRole, queryByText } = render(
<TestComponent
disableNext={true}
disabledNextTooltip="Complete all required fields to submit"
disabledNextTooltip="Complete all fields to submit"
loadingNext={true}
loadingNextTitle="Saving..."
/>,
Expand All @@ -218,7 +218,7 @@ describe('DirectionButtons', () => {

await waitFor(() => {
expect(
queryByText('Complete all required fields to submit'),
queryByText('Complete all fields to submit'),
).not.toBeInTheDocument();
});
});
Expand Down
2 changes: 1 addition & 1 deletion src/components/HrTools/Shared/CalculationReports/DirectionButtons/DirectionButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export const DirectionButtons: React.FC<DirectionButtonsProps> = ({
title={
disableNext && !loadingNext
? (disabledNextTooltip ??
t('Complete all required fields to continue'))
t('Complete all fields to continue'))
: ''
}
>
Expand Down
Loading