[MPDX-9595] Remove What's New link#1782
Conversation
|
Preview branch generated at https://9595-remove-whats-new-link.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 927da6b No significant changes found |
canac
left a comment
There was a problem hiding this comment.
Multi-Agent Code Review — VERDICT: CLEAN
Mode: quick (Architecture, Testing, Standards · sonnet)
Pure deletion PR (+0 −108): removes the env-var-gated "What's New" nav link across all 4 layers (next.config env passthrough → useNavPages → NavBar → NavItem/NavMenu) plus its tests and README docs.
Verification
yarn lint:tsexits 0- Zero remaining
whatsNewLink/HELP_WHATS_NEW/What's Newreferences insrc/,pages/,README.md,next.config.ts - No orphaned imports:
useTranslation/tcorrectly dropped fromNavMenu.tsx; correctly retained inNavItem.tsxanduseNavPages.tsxwhere still used - Only the dead-feature tests were removed — no collateral coverage loss for surviving behavior
- No breaking changes (feature was env-var gated, off by default)
Findings
0 blockers · 0 important · 0 medium · 1 informational
- (Informational, severity 1) The
"What's New"i18n key is now orphaned inpublic/locales/**(24 files). This path is an excluded/low-risk path per.claude/rules/code-review.md;yarn extract+ the next CrowdIn upload prunes it automatically. No action required. - (Note, not a defect)
.env.localstill containsHELP_WHATS_NEW_*— gitignored, not in this PR; clean up locally if desired.
Risk
Mechanical risk score is 10/10 (CRITICAL), driven solely by next.config.ts matching a Critical-file pattern. The actual change to that file is the removal of two process.env passthrough lines — no CSP, header, rewrite, or image-domain change. Real risk: LOW. This is a textbook clean feature removal.
| Agent | Crit | High | Imp | Sugg | Confidence |
|---|---|---|---|---|---|
| Architecture | 0 | 0 | 0 | 1 | High |
| Testing | 0 | 0 | 0 | 0 | High |
| Standards | 0 | 0 | 0 | 0 | High |
| Total | 0 | 0 | 0 | 1 |
Ready to merge.
There was a problem hiding this comment.
AI Review Auto-Approval
Risk Level: LOW (2/10)
Verdict: CLEAN (no issues found)
This PR was auto-approved because:
- The multi-agent AI review determined it is low risk
- No blocking issues were found
If you believe this PR needs human review, dismiss this approval and request a review manually.
Description
Stakeholders are ready to remove the temporary What's New link from the navbar.
MPDX-9595
Testing
Checklist:
/pr-reviewcommand locally and fixed any relevant suggestions