Skip to content

[MPDX-9595] Remove What's New link#1782

Merged
canac merged 1 commit into
mainfrom
9595-remove-whats-new-link
May 18, 2026
Merged

[MPDX-9595] Remove What's New link#1782
canac merged 1 commit into
mainfrom
9595-remove-whats-new-link

Conversation

@canac
Copy link
Copy Markdown
Contributor

@canac canac commented May 18, 2026

Description

Stakeholders are ready to remove the temporary What's New link from the navbar.

MPDX-9595

Testing

  • Go to any page
  • Check that the What's New link isn't in the navbar anymore

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
  • I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
  • I have requested a review from another person on the project
  • I have tested my changes in preview or in staging
  • I have cleaned up my commit history

@canac canac self-assigned this May 18, 2026
@canac canac added the Preview Environment Add this label to create an Amplify Preview label May 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Preview branch generated at https://9595-remove-whats-new-link.d3dytjb8adxkk5.amplifyapp.com

@github-actions
Copy link
Copy Markdown
Contributor

Bundle sizes [mpdx-react]

Compared against 927da6b

No significant changes found

Copy link
Copy Markdown
Contributor Author

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-Agent Code Review — VERDICT: CLEAN

Mode: quick (Architecture, Testing, Standards · sonnet)

Pure deletion PR (+0 −108): removes the env-var-gated "What's New" nav link across all 4 layers (next.config env passthrough → useNavPagesNavBarNavItem/NavMenu) plus its tests and README docs.

Verification

  • yarn lint:ts exits 0
  • Zero remaining whatsNewLink / HELP_WHATS_NEW / What's New references in src/, pages/, README.md, next.config.ts
  • No orphaned imports: useTranslation/t correctly dropped from NavMenu.tsx; correctly retained in NavItem.tsx and useNavPages.tsx where still used
  • Only the dead-feature tests were removed — no collateral coverage loss for surviving behavior
  • No breaking changes (feature was env-var gated, off by default)

Findings

0 blockers · 0 important · 0 medium · 1 informational

  • (Informational, severity 1) The "What's New" i18n key is now orphaned in public/locales/** (24 files). This path is an excluded/low-risk path per .claude/rules/code-review.md; yarn extract + the next CrowdIn upload prunes it automatically. No action required.
  • (Note, not a defect) .env.local still contains HELP_WHATS_NEW_* — gitignored, not in this PR; clean up locally if desired.

Risk

Mechanical risk score is 10/10 (CRITICAL), driven solely by next.config.ts matching a Critical-file pattern. The actual change to that file is the removal of two process.env passthrough lines — no CSP, header, rewrite, or image-domain change. Real risk: LOW. This is a textbook clean feature removal.

Agent Crit High Imp Sugg Confidence
Architecture 0 0 0 1 High
Testing 0 0 0 0 High
Standards 0 0 0 0 High
Total 0 0 0 1

Ready to merge.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Review Auto-Approval

Risk Level: LOW (2/10)
Verdict: CLEAN (no issues found)

This PR was auto-approved because:

  • The multi-agent AI review determined it is low risk
  • No blocking issues were found

If you believe this PR needs human review, dismiss this approval and request a review manually.

@canac canac merged commit 772e0d6 into main May 18, 2026
44 checks passed
@canac canac deleted the 9595-remove-whats-new-link branch May 18, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Preview Environment Add this label to create an Amplify Preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant