[MPDX-9594] - Clarify PDS Goal Calculator Pay Rate label and units

[wjames111]

Description

• Replaces the generic "Pay Rate" label in the PDS Goal Calculator Setup step with a dynamic label ("Annual Pay Rate" for salaried, "Hourly Pay Rate" for hourly) so the field's meaning matches the selected pay type.
• Adds an end adornment showing the unit ("/ year" or "/ hour") alongside the existing currency start adornment, making the entered value's period explicit.
• Updates the related SetupStep and PdsGoalCalculator tests to query the field by its new dynamic name and to assert both the label change and the unit suffix render correctly when toggling between salaried and hourly.

Related ticket: MPDX-9594

Testing

• Go to the HR Tools → PDS Goal Calculator
• Start (or continue) a goal and reach the Setup step
• Set Pay Type to Salaried and confirm the Pay Rate field is labeled "Annual Pay Rate", shows the currency symbol as a start adornment, and shows "/ year" as the end adornment with the helper text "Enter yearly salary"
• Switch Pay Type to Hourly and confirm the same field re-labels to "Hourly Pay Rate", the end adornment becomes "/ hour", and the helper text changes to "Enter hourly rate"
• Verify that the Pay Rate field is cleared when toggling Pay Type and that Continue remains disabled until a new Pay Rate is entered
• Confirm the field is hidden entirely when no Pay Type is selected

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
• I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
• I have requested a review from another person on the project
• I have tested my changes in preview or in staging
• I have cleaned up my commit history

[github-actions]

Bundle sizes [mpdx-react]

Compared against d5c2533

No significant changes found

[wjames111]

Multi-Agent Code Review — Verdict: CLEAN

PR #1787 — MPDX-9594 Clarify PDS Goal Calculator Pay Rate label and units

5 specialized review agents + dependency-impact analysis. No blockers, no important issues, no medium-priority findings. Only low-severity (3.0–4.5) optional refinements. Safe to merge after CI passes.

Risk Assessment

• Risk Score: 1/10 · Level: LOW
• 3 files changed (+20/-6); single-domain UX label/unit clarification on a goal-calculator setup field.
• No auth, schema, GraphQL, API, financial-calculation, or shared-component surface touched.

Coverage

• SetupStep.tsx — well-covered (Architecture, Testing, UX all reviewed)
• Both test files excluded from gap review (test-only, <20 lines changed)

Dependency-Impact Check

Other test files matching the string "Pay Rate" were investigated and confirmed unrelated to this change:

• Shared/Autosave/AutosaveTextField.test.tsx uses label="Pay Rate" as its own local fixture for the generic AutosaveTextField component.
• SupportItem/salaryBreakdown.test.tsx uses "Pay Rate" as a grid-cell category name, not the input field.

No external test breakage from this label change.

Standards Checklist — All PASS

· Named exports only · Component/test file naming · Localization (all 4 new strings wrapped in static t() calls, no interpolation, no dynamic keys) · No any introduced · No @ts-ignore / non-null assertions · Formik wiring preserved · Colocated tests · findBy* for async · No fetch mocking · No console.log/debugger/new Date()/unused imports/dead code · InputAdornment already imported (verified at SetupStep.tsx:12)

Financial Checklist

No financial calculation code in this PR. Label/adornment only; fieldName="payRate", Yup schema, and persisted value all unchanged. All checklist items N/A.

Review Summary

Agent	Critical	High	Important	Suggestions	Confidence
Architecture	0	0	0	1	High
Testing	0	0	0	2	High
Standards	0	0	0	0	High
UX	0	0	0	4	High
Financial Reporting	0	0	0	0	High
Total	0	0	0	7

Individual suggestions are posted as inline comments below — all are informational (severity < 5.0) and do not block merge.

[github-actions]

AI Review Auto-Approval

Risk Level: LOW (1/10)
Verdict: CLEAN (no issues found)

This PR was auto-approved because:

• The multi-agent AI review determined it is low risk
• No blocking issues were found

If you believe this PR needs human review, dismiss this approval and request a review manually.

[github-actions]

Preview branch generated at https://MPDX-9594.d3dytjb8adxkk5.amplifyapp.com