No-Jira - PDS Goal Calculator: Quick Geographic Location fix

[zweatshirt]

Description

We want to hide the geographic multiplier row information when there is no multiplier set.

Testing

• Go to ...
• Do ...
• Check that ...

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
• I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
• I have requested a review from another person on the project
• I have tested my changes in preview or in staging
• I have cleaned up my commit history

[github-actions]

Preview branch generated at https://improve-pds-geo.d3dytjb8adxkk5.amplifyapp.com

[github-actions]

Bundle sizes [mpdx-react]

Compared against 29a6e24

No significant changes found

[zweatshirt]

Multi-Agent Code Review — CLEAN ✓

Verdict: CLEAN — No issues found.

Risk: 1/10 (LOW) · 2 files · 9 source lines · single domain

Agents: Architecture, Testing, Standards, Financial Reporting (4 reviewers)

---

Summary

The geographicMultiplier === 0 guard is semantically correct: 0 is the "no adjustment" sentinel (sourced from goalGeographicConstantMap with ?? 0), and grossMonthlyPay = monthlyBase × (1 + 0) = monthlyBase exactly in IEEE-754. Showing "Monthly Base" instead of "× Geographic Multiplier (100%)" removes misleading noise. Both new translation keys are properly localized. Both branches have test coverage.

All findings below are informational suggestions — none block merge.

---

Financial Checklist

• Arithmetic on money values safe: ✓
• Rounding at display boundary only: ✓
• Formula label matches computed amount: ✓ (multiply-by-1.0 is bit-exact)
• Null/undefined amounts handled: ✓ (?? 0 present)

[zweatshirt]

[Suggestion] This test verifies the formula label but not that `row?.amount` equals the monthly base when the multiplier is 0. The amount is covered by a separate test elsewhere, but asserting both here would lock label/amount agreement in one place:

expect(row?.formula).toBe('Monthly Base');
expect(row?.amount).toBe(salariedCalculation.monthlyBase); // or the expected number

Not blocking — just strengthens the invariant.

[zweatshirt]

[Suggestion] The strict `=== 0` guard is correct given that `geographicMultiplier` comes from `goalGeographicConstantMap` with `?? 0` (only exact zero is the "no adjustment" sentinel). Worth a brief comment to document this assumption so a future reader doesn't wonder whether very small values (e.g. `0.0001`) should also render "Monthly Base".

[zweatshirt]

[Suggestion] The non-zero branch is covered with `0.06`. If negative multipliers are reachable from `goalGeographicConstantMap` (sub-baseline cost-of-living regions), a negative test case would document the intended behavior (e.g. `-0.06` → `94%`). Skip if negative values aren't possible in practice.

[github-actions]

AI Review Auto-Approval

Risk Level: LOW (1/10)
Verdict: CLEAN (no issues found)

This PR was auto-approved because:

• The multi-agent AI review determined it is low risk
• No blocking issues were found

If you believe this PR needs human review, dismiss this approval and request a review manually.