Skip to content

MPDX-9629, MPDX-9630 Salary Calc UAT #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kegrimes wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −11
Open

MPDX-9629, MPDX-9630 Salary Calc UAT #1799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25a3970
Fix salary calc page title
May 22, 2026
6b67f15
Fixed wrong menu options showing
May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pages/accountLists/[accountListId]/hrTools/salaryCalculator/[calculationId]/index.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const SalaryCalculatorEditInnerPage: React.FC = () => {
return (
<>
<Head>
<title>{`${appName} | ${t('Salary Calculator')}`}</title>
<title>{`${appName} | ${t('HR Tools | Salary Calculation Form')}`}</title>
</Head>
<UserTypeAccess
requireStaffAccount
Expand All @@ -68,7 +68,7 @@ const SalaryCalculatorEditInnerPage: React.FC = () => {
isOpen={isNavListOpen}
selectedId="salaryCalculator"
onClose={handleNavListToggle}
navType={NavTypeEnum.Reports}
navType={NavTypeEnum.HrTools}
/>
}
leftOpen={isNavListOpen}
Expand All @@ -78,8 +78,8 @@ const SalaryCalculatorEditInnerPage: React.FC = () => {
<MultiPageHeader
isNavListOpen={isNavListOpen}
onNavListToggle={handleNavListToggle}
title={t('Salary Calculator')}
headerType={HeaderTypeEnum.Report}
title={t('Salary Calculation Form')}
headerType={HeaderTypeEnum.HrTools}
rightExtra={<SalaryCalculatorSavingStatus />}
/>
<SalaryCalculator />
Expand Down
2 changes: 1 addition & 1 deletion pages/accountLists/[accountListId]/hrTools/salaryCalculator/index.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const SalaryCalculatorPage: React.FC = () => {
<MultiPageHeader
isNavListOpen={isNavListOpen}
onNavListToggle={handleNavListToggle}
title={t('Salary Calculator')}
title={t('Salary Calculation Form')}
headerType={HeaderTypeEnum.HrTools}
/>

Expand Down
12 changes: 6 additions & 6 deletions pages/accountLists/[accountListId]/hrTools/salaryCalculator/salaryCalculator.page.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ const TestComponent: React.FC<TestComponentProps> = ({

describe('SalaryCalculatorPage', () => {
it('renders the Salary Calculator header', async () => {
const { findByRole } = render(<TestComponent />);
const { findAllByRole } = render(<TestComponent />);
expect(
await findByRole('heading', { name: /Salary Calculator/i }),
).toBeInTheDocument();
await findAllByRole('heading', { name: /Salary Calculation Form/i }),
).toHaveLength(2);
});

it('uses blockImpersonatingNonDevelopers for server-side props', () => {
Expand All @@ -44,15 +44,15 @@ describe('SalaryCalculatorPage', () => {
});

it('renders NewSalaryCalculatorLanding when shouldShowPending is false', async () => {
const { findByRole } = render(
const { findAllByRole } = render(
<LandingTestWrapper>
<SalaryCalculatorPage />
</LandingTestWrapper>,
);

expect(
await findByRole('heading', { name: 'Salary Calculator' }),
).toBeInTheDocument();
await findAllByRole('heading', { name: 'Salary Calculation Form' }),
).toHaveLength(2);
});
});

Expand Down
Loading