Migrate ABViewGrid#349
Open
benthongtiang wants to merge 1 commit into
Open
Conversation
benthongtiang
added
the
patch
johnny-hausman
requested changes
May 18, 2026
Collaborator
johnny-hausman
left a comment
johnny-hausman
left a comment
There was a problem hiding this comment.
check to see if those files should be brought into the plugin code.
|
|
||
| static getPluginKey() { | ||
| return this.key; | ||
| } |
Collaborator
There was a problem hiding this comment.
make sure you have eslint + prettier setup to run on these files.
The spacing is all off.
| import FPopupSummaryFields from "../../rootPages/Designer/ui_work_object_workspace_popupSummaryColumns"; | ||
|
|
||
| import FABViewPropertyFilterData from "../../rootPages/Designer/properties/views/viewProperties/ABViewPropertyFilterData"; | ||
| import FABViewPropertyLinkPage from "../../rootPages/Designer/properties/views/viewProperties/ABViewPropertyLinkPage"; |
Collaborator
There was a problem hiding this comment.
check to see if any of these additional imported files are used by any other component. If not, then pull them into the web_view_grid package since they seem part of the definition of the grid object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate ABViewGrid properties and editor to the plugin architecture